Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KH2: Fix empty location groups #2757

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Conversation

JaredWeakStrike
Copy link
Collaborator

Please format your title with what portion of the project this pull request is
targeting and what it's changing.

ex. "MyGame4: implement new game" or "Docs: add new guide for customizing MyGame3"

What is this fixing or adding?

removes the empty location groups from the data package

How was this tested?

genned a seed and ran unittests

If this makes graphical changes, please attach screenshots.

Co-authored-by: Aaron Wagener <mmmcheese158@gmail.com>
Copy link
Collaborator

@alwaysintreble alwaysintreble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the typing of location_groups is incorrect and i don't really understand why it's on a separate line, but those are out of scope for this PR so the changes lgtm

@ScipioWright ScipioWright added the is: refactor/cleanup Improvements to code/output readability or organizization. label Jan 26, 2024
Copy link
Collaborator

@ScipioWright ScipioWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Berserker66 Berserker66 merged commit 69c8050 into ArchipelagoMW:main Jan 29, 2024
12 checks passed
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
Co-authored-by: Aaron Wagener <mmmcheese158@gmail.com>
TheLX5 pushed a commit to TheLX5/Archipelago that referenced this pull request Mar 2, 2024
Co-authored-by: Aaron Wagener <mmmcheese158@gmail.com>
TheLX5 pushed a commit to TheLX5/Archipelago that referenced this pull request Mar 2, 2024
Co-authored-by: Aaron Wagener <mmmcheese158@gmail.com>
@JaredWeakStrike JaredWeakStrike deleted the patch-1 branch April 14, 2024 23:06
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
Co-authored-by: Aaron Wagener <mmmcheese158@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: refactor/cleanup Improvements to code/output readability or organizization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants