Adventure: Fix iterable copy error when freeincarnate_max is tuned low #2774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarno458
added
the
is: bug/fix
Berserker66
approved these changes
Jan 29, 2024
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
TheLX5
pushed a commit
to TheLX5/Archipelago
that referenced
this pull request
Mar 2, 2024
TheLX5
pushed a commit
to TheLX5/Archipelago
that referenced
this pull request
Mar 2, 2024
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Fixing errors in Adventure pre_fill due to calling .copy on what is now an iterable and not a list. Would hit this code if there were not enough items to fill all locations, mainly when max_freeincarnate is set to a low value.
How was this tested?
Generated full-random 1050 Adventure multiworld, 100 full-random individual single-adventure multiworlds, and generated and played some of a 4 Adventure world with low random max_freeincarnate settings
If this makes graphical changes, please attach screenshots.
N/A