-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zillion: apworld-compatible package data #2860
Zillion: apworld-compatible package data #2860
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not test the whole Windows frozen build.
(I don't know how to build it and don't use Windows.)
I just tested freezing it, and instead of a lib/worlds/zillion/
folder there is now a lib/worlds/zillion.apworld
🥳
Launching Zillion both via the Launcher and via ArchipelagoZillionClient.exe work.
Map in the client looks right.
Ran a test gen with ArchipelagoGenerate.exe, it asked for my ROM then generated successfully.
Open Patch in the launcher on the apzd which launched the zillion client and got myself a patched .sms ROM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Client change look good (map shows up), but the world is still not fully APWorld-compatible and fails to load for py3.8 here:
https://github.com/beauxq/Archipelago/blob/zillion-apworld-module-data/worlds/zillion/__init__.py#L28
See https://github.com/ArchipelagoMW/Archipelago/blob/main/docs/apworld%20specification.md#caveats
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* Zillion: apworld-compatible module data * fixed `World` import
* Zillion: apworld-compatible module data * fixed `World` import
What is this fixing or adding?
changed some package data access to use
pkgutil
so that it can be accessed from an apworld
I think that makes it work as an internal apworld.
("internal" =
zillion/requirements.txt
is installed in the frozen build, andZillionClient.py
is built)How was this tested?
zillion
folder.apworld
zillion
folderMultiServer
, toggling map tracker off and on and watching it for accuracyI did not test the whole Windows frozen build.
(I don't know how to build it and don't use Windows.)
But I'm confident any problem with that would be found in release candidate phase.
edit: Thank you remyjette for testing the Windows frozen build.