Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zillion: apworld-compatible package data #2860

Merged
merged 2 commits into from
Mar 3, 2024

Conversation

beauxq
Copy link
Collaborator

@beauxq beauxq commented Feb 24, 2024

What is this fixing or adding?

changed some package data access to use pkgutil
so that it can be accessed from an apworld

I think that makes it work as an internal apworld.
("internal" = zillion/requirements.txt is installed in the frozen build, and ZillionClient.py is built)

How was this tested?

  • zipped up the zillion folder
  • renamed it .apworld
  • removed the original zillion folder
  • generated 1-player Zillion game
  • played through the game connected to MultiServer, toggling map tracker off and on and watching it for accuracy

I did not test the whole Windows frozen build.
(I don't know how to build it and don't use Windows.)
But I'm confident any problem with that would be found in release candidate phase.
edit: Thank you remyjette for testing the Windows frozen build.

@github-actions github-actions bot added waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. affects: core Issues/PRs that touch core and may need additional validation. labels Feb 24, 2024
@beauxq
Copy link
Collaborator Author

beauxq commented Feb 24, 2024

affects: core is just the setup.py removing Zillion from the apworld exclusion list

@beauxq beauxq changed the title Zillion: apworld-compatible module data Zillion: apworld-compatible package data Feb 24, 2024
Copy link
Collaborator

@remyjette remyjette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not test the whole Windows frozen build.
(I don't know how to build it and don't use Windows.)

I just tested freezing it, and instead of a lib/worlds/zillion/ folder there is now a lib/worlds/zillion.apworld 🥳

Launching Zillion both via the Launcher and via ArchipelagoZillionClient.exe work.

Map in the client looks right.

Ran a test gen with ArchipelagoGenerate.exe, it asked for my ROM then generated successfully.
Open Patch in the launcher on the apzd which launched the zillion client and got myself a patched .sms ROM.

@ScipioWright ScipioWright added is: refactor/cleanup Improvements to code/output readability or organizization. is: enhancement Issues requesting new features or pull requests implementing new features. and removed is: refactor/cleanup Improvements to code/output readability or organizization. labels Feb 26, 2024
Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Client change look good (map shows up), but the world is still not fully APWorld-compatible and fails to load for py3.8 here:
https://github.com/beauxq/Archipelago/blob/zillion-apworld-module-data/worlds/zillion/__init__.py#L28

See https://github.com/ArchipelagoMW/Archipelago/blob/main/docs/apworld%20specification.md#caveats

@beauxq beauxq requested a review from black-sliver March 3, 2024 15:11
Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@black-sliver black-sliver merged commit ef37ee8 into ArchipelagoMW:main Mar 3, 2024
18 checks passed
@github-actions github-actions bot removed the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Mar 3, 2024
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
* Zillion: apworld-compatible module data

* fixed `World` import
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
* Zillion: apworld-compatible module data

* fixed `World` import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: enhancement Issues requesting new features or pull requests implementing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants