Bomb Rush Cyberfunk: Implement new game #2925
Merged
+3,296
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TRPG0
added
the
is: new game
github-actions
bot
added
the
waiting-on: peer-review
ScipioWright
added
the
waiting-on: author
ScipioWright
approved these changes
Mar 14, 2024
ScipioWright
removed
the
waiting-on: author
DeamonHunter
suggested changes
Apr 15, 2024
There was a problem hiding this comment.
I'm not the most knowledgeable person with Python, so I may be missing some issues. That being said, the main issue is the indentation of several funcs in rules making it hard to parse.
Would also recommend making some tests, in particular:
- A test to ensure that adding/remove rep items works as intended. (Due to collect and remove)
- A test to ensure the correct graffiti count is gotten at various points in the game. (So that refactoring or other changes in that area doesn't break other parts.)
- Adjust description for "Extra REP Required" option - Rework graffiti spot rules - Adjust game docs - Add more tests
Oops (it actually still does what it's supposed to anyway because of how my methods from `Rules.py` work but still)
DeamonHunter
approved these changes
Apr 21, 2024
ScipioWright
added
waiting-on: core-review
qwint
reviewed
Apr 30, 2024
Berserker66
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Adds Team Reptile's Bomb Rush Cyberfunk as a new game.
How was this tested?
Game has been playable and open for anyone to try in its own #future-game-design thread for ~5 months.
If this makes graphical changes, please attach screenshots.