MultiServer: add all worlds goal completion message #2956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: core
|
Is it tested with item links? (since item links make fake player slots) |
Just tested, groups are always considered goal completed by the server. They cause no issue for this implementation. |
remyjette
added
the
is: enhancement
remyjette
approved these changes
Mar 15, 2024
Ixrec
approved these changes
Mar 20, 2024
MultiServer.py
Outdated
| @@ -1839,6 +1839,15 @@ def update_client_status(ctx: Context, client: Client, new_status: ClientStatus) | |||
| if current != ClientStatus.CLIENT_GOAL: # can't undo goal completion | |||
| if new_status == ClientStatus.CLIENT_GOAL: | |||
| ctx.on_goal_achieved(client) | |||
| relevant_players = [player for player in ctx.player_names | |||
There was a problem hiding this comment.
Maybe rest_of_team or other_players_in_team would be even clearer?
Exempt-Medic
added
waiting-on: core-review
Berserker66
reviewed
Apr 13, 2024
MultiServer.py
Outdated
Comment on lines
1842
to
1850
| relevant_players = [player for player in ctx.player_names | ||
| if player[0] == client.team and player[1] != client.slot] | ||
| for player in relevant_players: | ||
| if player not in ctx.client_game_state: | ||
| break # player has yet to ever connect to the server | ||
| if ctx.client_game_state[player] != ClientStatus.CLIENT_GOAL: | ||
| break | ||
| else: | ||
| ctx.broadcast_text_all(f"Team #{client.team + 1} has completed all of their games! Congratulations!") |
There was a problem hiding this comment.
Suggested change
| relevant_players = [player for player in ctx.player_names | |
| if player[0] == client.team and player[1] != client.slot] | |
| for player in relevant_players: | |
| if player not in ctx.client_game_state: | |
| break # player has yet to ever connect to the server | |
| if ctx.client_game_state[player] != ClientStatus.CLIENT_GOAL: | |
| break | |
| else: | |
| ctx.broadcast_text_all(f"Team #{client.team + 1} has completed all of their games! Congratulations!") | |
| if all(player in ctx.client_game_state and ctx.client_game_state[player] == ClientStatus.CLIENT_GOAL for player in ctx.player_names if player[0] in client.team): | |
| ctx.broadcast_text_all(f"Team #{client.team + 1} has completed all of their games! Congratulations!") |
didn't test, just wrote it up in github.
There was a problem hiding this comment.
You'd need to ignore the current player (since ctx.client_game_state is not changed yet), but this probably works. I'll test it soon.
beauxq
reviewed
Apr 14, 2024
beauxq
reviewed
Apr 14, 2024
Co-authored-by: Doug Hoskisson <beauxq@users.noreply.github.com>
Berserker66
approved these changes
Apr 14, 2024
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Upon the last world in a team sending goal completion, a message is sent to all players congratulating the team.
How was this tested?
Several games of multiple Clique, confirming that the message would only be sent on the final goal completion.
If this makes graphical changes, please attach screenshots.