Adventure: Remove runtime changes to location templates to fix determinism issues #3010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix determinism issues
github-actions
bot
added
the
waiting-on: peer-review
There was a problem hiding this comment.
I don't think I'm qualified to approve this PR, as I'm not familiar with either the code nor the game.
But I figured I should say I at least looked at it, considering I'm the one who asked for this to get fixed.
Couldn't find anything wrong with it, but that doesn't mean much since I didn't understand much of it
| @@ -19,9 +19,9 @@ def __init__(self, room_id: int, room_x: int = None, room_y: int = None): | |||
|
|
|||
| def get_position(self, random): | |||
There was a problem hiding this comment.
Would be nice to get some type hinting in these methods
alwaysintreble
added
the
is: bug/fix
Berserker66
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Does not assign room id or room_x, room_y to the fixed location table entries (except room_id in some cases when it only can have a single possible value).
How was this tested?
Ran determinism test from #2977, all other tests, generated a couple 2600 world multiworlds, generated a few 1 and 4 world Adventure multiworlds and played one of them..
If this makes graphical changes, please attach screenshots.
N/A