Faxanadu: implement new game

[Daivuk]

What is this fixing or adding?

New game, Faxanadu.

Faxanadu is an NES game. It does not require the server to have the ROM to generate. The patching is done at runtime in the client. The client is a custom-made NES emulator for AP Faxanadu. (Called Daxanadu, because my name is Daivuk...)

The client can be found here: https://github.com/Daivuk/Daxanadu

How was this tested?

It has been played for months. apworld was available since a while.

If this makes graphical changes, please attach screenshots.

The palette on the NES is restricted, especially in this game. Only 3 colors could have been used for the AP icon. Here how it looks in-game:

Or it shows the proper graphic if they are your own items:

In the menus, the icon has a different palette. Here an example receiving progression item:

Followed by a dialog explaining what it is:

When an AP item is bought from a shop, it shows "SOLD OUT":

More client-only options that don't affect the randomizer, are available in the client:

There is also an option in the client to disable cigarette imagery. This is done by patching the sprites with a "diff" sprite. The diff sprites just include the pixels that need to be covered by something new. They don't look like much by themselves.

[ScipioWright]

Just some brief comments, looks pretty good as always.
Obviously there's those test failures too that need to be solved

[Silvris]

Make sure to add Faxanadu to README.md as well.

[Daivuk]

Done the requested changes, and tested locally.

[qwint]

reviewed all of the code and the relevant pages in local webhost and added relevant inline comments. All docs comments are typos or suggestions for more natural English sentences.
benchmarks ran ok, but there were some outliers in location access rules that could be optimized but weren't larger than .21 seconds, and load_worlds was great
no issues in running tests locally in 3.8 or 3.11

did not generate any games nor use the client

[Daivuk]

Done the requested changes, and tested locally.

[qwint]

barring my new small comment on returning red_potion_in_shop_count #3059 (comment)
and my discussion on RequireDragonSlayer's docstring everything looks good from my review
I'd still like those addressed but I would be happy as-is so approving

[Daivuk]

barring my new small comment on returning red_potion_in_shop_count #3059 (comment) and my discussion on RequireDragonSlayer's docstring everything looks good from my review I'd still like those addressed but I would be happy as-is so approving

Oversights, fixed.

[qwint]

one more thing i didn't notice before, you should add the return typing hints for prefill_shop_red_potions() and prefill_shop_wingboots()

[Daivuk]

one more thing i didn't notice before, you should add the return typing hints for prefill_shop_red_potions() and prefill_shop_wingboots()

Ok done

[qwint]

you put the hint on put_wingboot_in_shop() not prefill_shop_wingboots() which is the one who returns wingboots count

[Daivuk]

you put the hint on put_wingboot_in_shop() not prefill_shop_wingboots() which is the one who returns wingboots count

I went too fast 😄 . Fixed

[qwint]

reapproving after the last couple comments were addressed as well
also, fyi the force-pushes make it harder to review just the new changes from review, but at least this world is small enough that it's not that bad

[Daivuk]

reapproving after the last couple comments were addressed as well also, fyi the force-pushes make it harder to review just the new changes from review, but at least this world is small enough that it's not that bad

Ok I do this to keep the PR clean, as it's the first commit for this game. It's what we do at work to, force of habit. Squash/amend

[Daivuk]

Before anyone merge, I have to do a commit there was a logic issue I had noted that I forgot to fix.

[Daivuk]

Before anyone merge, I have to do a commit there was a logic issue I had noted that I forgot to fix.

Ok the logic fix is in