DKC3: Fix List Out of Range Error on Level Shuffle Hint extension

[PoryGone]

What is this fixing or adding?

In #2820, I moved hint extension from modify_multidata, which was run on a thread, to extend_hint_information, which apparently isn't, and now that it's running on the main thread, it can be seen that it actually crashes at the end from an off-by-one error. It doesn't do that anymore.

(Also I noticed a player-facing name had an underscore and no one has ever commented on it)

How was this tested?

I actually generated with a level shuffle seed, which I apparently failed to do last PR.

If this makes graphical changes, please attach screenshots.

[Ixrec]

Never played DKC3, but it seems clear this would successfully ignore the off-by-one error instead of raising an exception.

Though without any context besides this PR itself, this does feel more like a workaround/mitigation than an actual fix. Is the idea that some of these worlds are sometimes unavailable, so it's perfectly correct behavior to end up with an out of bounds index for worlds/levels that "don't exist"? Or is there a "real" bug with hint info that still need a more involved fix?

[alwaysintreble]

code itself is fine

[alwaysintreble]

since i don't see it mentioned in your PR description is this also a bug fix?

[alwaysintreble]

ah it was surrounded in () that's why i didn't see it. then i suppose i just need to ask if it's used in code anywhere as a precaution

[PoryGone]

LocationName.lake_orangatanga_region is used throughout the code. That is the purpose of this file.

[PoryGone]

Never played DKC3, but it seems clear this would successfully ignore the off-by-one error instead of raising an exception.

Though without any context besides this PR itself, this does feel more like a workaround/mitigation than an actual fix. Is the idea that some of these worlds are sometimes unavailable, so it's perfectly correct behavior to end up with an out of bounds index for worlds/levels that "don't exist"? Or is there a "real" bug with hint info that still need a more involved fix?

Rocket Rush is never (and will never be) randomized. It is the 5th level in the final world. Every world has 5 levels.
This is a full solution, not a band-aid.