TUNIC: Error catching for logic bugs in ER #3082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScipioWright
added
the
is: refactor/cleanup
github-actions
bot
added
the
waiting-on: peer-review
NewSoupVi
approved these changes
Apr 3, 2024
worlds/tunic/__init__.py
Outdated
| warning(f"{location.name} is not logically accessible for " | ||
| f"{self.multiworld.get_file_safe_player_name(self.player)}. " | ||
| "Creating entrance hint Inaccessible. " | ||
| "Please report this to the Tunic rando devs.") |
There was a problem hiding this comment.
This is not nearly funny enough, needs to have at least 3 layers of self-deprecation or flirty vibes /j
ScipioWright
added
waiting-on: core-review
Berserker66
approved these changes
Apr 11, 2024
Berserker66
added
waiting-on: world-maintainer
|
For worlds with multiple maintainers, are we meant to get approvals from all of the maintainers? I'm the main one doing all of the entrance rando stuff, so this doesn't really have anything to do with Silent |
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Currently, if there was an error encountered where a location is unreachable in entrance rando, it would raise an exception that isn't the most clear to a host.
Now, it'll log a warning and make the entrance hint "Inaccessible". This is so that gen can continue, since I wouldn't want something like this that doesn't always lead to a game that can't be beaten to stop games from happening.
There aren't any currently known bugs in the entrance rando logic, this is mostly a just in case.
How was this tested?
Test gens.
Easy way to test is to go to the line in er_scripts that is
while len(connected_regions) < len(non_dead_end_regions):and change it towhile len(connected_regions) < len(non_dead_end_regions) - 10:, with the entrance rando option enabled in the yaml. It might take a few tries for it to actually proc.If this makes graphical changes, please attach screenshots.
N/A