Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LTTP: Fix Bug With Custom Resource Spending #3105

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

Alchav
Copy link
Contributor

@Alchav Alchav commented Apr 6, 2024

What is this fixing or adding?

Fixes a bug where if you would have 17 or more hearts left after spending hearts to buy an item, you're told you can't afford it.
Companion PR to z3randomizer here: ArchipelagoMW/z3randomizer#10

How was this tested?

Generating a game, successfully buying a 2 heart cost item while having 20 hearts. Rewinding, bringing hearts down to 2, trying again, confirming it will still not allow you to buy.

@Alchav Alchav requested a review from Berserker66 as a code owner April 6, 2024 16:28
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Apr 6, 2024
@alwaysintreble alwaysintreble added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. labels Apr 6, 2024
@Berserker66 Berserker66 merged commit 8d9bd01 into ArchipelagoMW:main Apr 6, 2024
15 checks passed
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants