sc2: Fixing mission levels not counting towards the level 35 threshold #3109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to unlock primal kerrigan
github-actions
bot
added
the
waiting-on: peer-review
14 tasks
Ziktofel
added
the
is: bug/fix
Ziktofel
approved these changes
Apr 7, 2024
Salzkorn
approved these changes
Apr 7, 2024
Ziktofel
added
waiting-on: core-review
Bicoloursnake
approved these changes
Apr 8, 2024
Berserker66
approved these changes
Apr 13, 2024
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
…d to unlock primal kerrigan (ArchipelagoMW#3109)
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
…d to unlock primal kerrigan (ArchipelagoMW#3109)
MatthewMarinets
deleted the
mm/fix_kerrigan_mission_levels_not_counting_towards_primal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing mission levels not counting towards the level 35 threshold to unlock primal Kerrigan.
What is this fixing or adding?
Reported by JarJarThinks in the Discord 2024-04-06:
When KerriganPrimalStatus is set to level_35, Kerrigan is supposed to become Primal if her level is 35 or higher. However, the client-side check on her level was calculating based on items, which didn't account for levels that could come from completing missions.
How was this tested?
I developed this on a branch that let me change the levels per check option dynamically, and have it apply on next mission startup. I completed one mission, set levels per check to 34, and opened a map to ensure Kerrigan was in her Ghost form. Then I exited, updated the option to 35, opened the mission again, and saw Kerrigan was now primal.
If this makes graphical changes, please attach screenshots.