Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SC2: Fix possible non-determinism in goal selection #3123

Merged
merged 1 commit into from
Apr 11, 2024
Merged

SC2: Fix possible non-determinism in goal selection #3123

merged 1 commit into from
Apr 11, 2024

Conversation

Ziktofel
Copy link
Collaborator

@Ziktofel Ziktofel commented Apr 9, 2024

What is this fixing or adding?

https://discord.com/channels/731205301247803413/1227239356272607262
Sorts campaigns that are subjects to goal selection prior picking the one containing the goal

How was this tested?

The game still successfully generates

If this makes graphical changes, please attach screenshots.

No

@Ziktofel Ziktofel added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Apr 9, 2024
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Apr 9, 2024
Bicoloursnake
Bicoloursnake approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@Bicoloursnake Bicoloursnake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If anyone else was trying to figure out what nondeterminism this would tackle, enabled_campaigns is a set.

@Ziktofel Ziktofel added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Apr 9, 2024
@Berserker66 Berserker66 merged commit 9012afe into ArchipelagoMW:main Apr 11, 2024
15 checks passed
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
@Ziktofel @EmilyV99
SC2: Fix possible non-determinism in goal selection (ArchipelagoMW#3123)
82dd6c1
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
@Ziktofel @EmilyV99
SC2: Fix possible non-determinism in goal selection (ArchipelagoMW#3123)
19abadf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Berserker66 Berserker66 Berserker66 approved these changes

@Alchav Alchav Alchav approved these changes

@Bicoloursnake Bicoloursnake Bicoloursnake approved these changes

Assignees
No one assigned
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ziktofel @Berserker66 @Alchav @Bicoloursnake