Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALTTP: Updates to player-specific game tracker. #3133

Merged
merged 5 commits into from
Apr 20, 2024
Merged

ALTTP: Updates to player-specific game tracker. #3133

merged 5 commits into from
Apr 20, 2024

Conversation

ThePhar
Copy link
Member

@ThePhar ThePhar commented Apr 12, 2024

What is this fixing or adding?

  • Adds dropdown tables, separated by region, for each location and its checked status.
  • Adds Bombs for bombless-start seeds.
  • Adds Triforce Pieces to track.
  • Add support for KDS, Take-Any, Shop locations.
  • Add light and dark overworld regions for tracking.
  • Update icon image URLs to match in-game sprites closer.
  • Fix issue with grouped non-progressive items not updating properly.
  • Add alt and title text for if images fail to load or mousing over icon.

This does not make changes to the multi-tracker for ALTTP. That will be coming in another PR.

How was this tested?

Ran a test game and watched updates flow through.

If this makes graphical changes, please attach screenshots.

image

@ThePhar
ALTTP: Massive game tracker update.
c7da309 
* Adds dropdowns separated by region for each location and its checked status.
* Adds Bombs for bombless start seeds.
* Adds Triforce Pieces to track.
* Update icon image URLs to match in-game closer.
* Fix issue with grouped progressive items.
@ThePhar
Couple missed points.
1652b3c
@ThePhar
Another edge case with details being refreshed.
93c13d6
@ThePhar ThePhar added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. is: enhancement Issues requesting new features or pull requests implementing new features. affects: webhost Issues/PRs that touch webhost and may need additional validation. labels Apr 12, 2024
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Apr 12, 2024
@ThePhar
Copy link
Member Author

ThePhar commented Apr 12, 2024

Requesting review from Berserker since it is the ALTTP tracker.

@ThePhar ThePhar added the waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. label Apr 13, 2024
@LegendaryLinux LegendaryLinux self-requested a review April 16, 2024 21:05
LegendaryLinux
LegendaryLinux approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@LegendaryLinux LegendaryLinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unable to checkout the branch myself, but having looked through the HTML/CSS changes, they look fine to me.

@ThePhar ThePhar removed the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Apr 18, 2024
@ThePhar ThePhar merged commit 0a1ce5b into ArchipelagoMW:main Apr 20, 2024
16 checks passed
@ThePhar ThePhar deleted the alttp_game_tracker_updates branch April 20, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LegendaryLinux LegendaryLinux LegendaryLinux approved these changes

@Berserker66 Berserker66 Awaiting requested review from Berserker66

Assignees
No one assigned
Labels
affects: webhost Issues/PRs that touch webhost and may need additional validation. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ThePhar @LegendaryLinux