SM64ex: Logic and Generation Fixes #3135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Magnemania <magnemight@gmail.com>
Signed-off-by: Magnemania <magnemight@gmail.com>
… to the pillars and ground pounding on top of them in basic logic. Shell is considered capless method. Signed-off-by: Magnemania <magnemight@gmail.com>
Signed-off-by: Magnemania <magnemight@gmail.com>
Signed-off-by: Magnemania <magnemight@gmail.com>
Signed-off-by: Magnemania <magnemight@gmail.com>
Signed-off-by: Magnemania <magnemight@gmail.com>
Signed-off-by: Magnemania <magnemight@gmail.com>
github-actions
bot
added
the
waiting-on: peer-review
Exempt-Medic
added
the
is: bug/fix
| @@ -246,6 +247,7 @@ class RuleFactory: | |||
|
|
|||
| token_table = { | |||
| "TJ": "Triple Jump", | |||
| "DJ": "Triple Jump", | |||
There was a problem hiding this comment.
Is this supposed to be Triple Jump?
There was a problem hiding this comment.
"Triple Jump" the item unlocks both "DJ (Double Jump)" and "TJ (Triple Jump)" in the logic. Doesn't serve a purpose in the rules currently, but it lets anyone looking at the file know that DJ requires Triple Jump.
This was going to be part of a greater logic rework that replaced TJ with DJ in some rules to future-proof the logic for when DJ gets the option to be randomized separately, but that's a big feature addition
remyjette
added a commit
to remyjette/Archipelago
that referenced
this pull request
Apr 12, 2024
N00byKing
approved these changes
Apr 13, 2024
Signed-off-by: Magnemania <magnemight@gmail.com>
Berserker66
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
can_reachto remove accessibility check errors. Ignored the legacy entrance dependencies on the Bowser in the Fire Sea entrance (entrance entrance rule depends on a location) as that rule has been around for several versions and has never been reported causing a failure.How was this tested?
100 generations with everything randomized, and 100 generations with everything randomized except moves. Went over a few spoiler logs by eye.
(This was originally going to be part of a larger logic polish-up, but I wanted to get these fixes through in time for the big async, as the accessibility check issues could become relevant when generating and the strict move requirements issue could create extremely difficult checks without player consent)