Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOOM 1993: Update to use new Options + logic fixes + Doc fix #3138

Merged
merged 4 commits into from
Apr 18, 2024
Merged

DOOM 1993: Update to use new Options + logic fixes + Doc fix #3138

merged 4 commits into from
Apr 18, 2024

Conversation

Daivuk
Copy link
Collaborator

@Daivuk Daivuk commented Apr 13, 2024 •
edited

What is this fixing or adding?

  • Changed old Options to use the new @DataClass options
  • Added info in doc on which folder to find your WAD file in your steam library
  • Fixed logic issue for entry to E2M8:
    image
  • Renamed variables world -> multiworld

How was this tested?

  • Locally. Minor changes. The logic issue was reported and logged months ago

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Apr 13, 2024
Silvris
Silvris approved these changes Apr 13, 2024
View reviewed changes
Copy link
Collaborator

@Silvris Silvris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not run, but changes look correct. Now might also be a good time to cleanup instances of world: Multiworld in the world as well though.

@ScipioWright ScipioWright added the is: refactor/cleanup Improvements to code/output readability or organizization. label Apr 14, 2024
@Exempt-Medic Exempt-Medic added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. is: documentation Improvements or additions to documentation. labels Apr 14, 2024
@Berserker66 Berserker66 merged commit ffff63e into ArchipelagoMW:main Apr 18, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Berserker66 Berserker66 Berserker66 approved these changes

@Silvris Silvris Silvris approved these changes

Assignees
No one assigned
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. is: documentation Improvements or additions to documentation. is: refactor/cleanup Improvements to code/output readability or organizization. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Daivuk @Berserker66 @Silvris @ScipioWright @Exempt-Medic