Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebHost: check: display exception chain one layer deep #3153

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

Berserker66
Copy link
Member

What is this fixing or adding? How was this tested? If this makes graphical changes, please attach screenshots.

Before:
image

After:
image

@github-actions github-actions bot added affects: webhost Issues/PRs that touch webhost and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Apr 15, 2024
WebHostLib/check.py Outdated Show resolved Hide resolved
WebHostLib/check.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@beauxq beauxq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test.
I just looked up the type of __cause__ (BaseException | None)

Copy link
Member

@LegendaryLinux LegendaryLinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, looks good.

@LegendaryLinux LegendaryLinux merged commit 38c54ba into main Apr 16, 2024
24 checks passed
@Berserker66 Berserker66 deleted the webhost_check_chain branch April 16, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: webhost Issues/PRs that touch webhost and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants