Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stardew Valley: Options page documentation improvements #3155

Merged

Conversation

agilbert1412
Copy link
Collaborator

What is this fixing or adding?

1: Fixed a typo (leaning -> learning)
2: Shortened the goal documentation so that the tooltip is more readable (hopefully)

How was this tested?

Documentation

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Apr 15, 2024
@agilbert1412 agilbert1412 added the is: documentation Improvements or additions to documentation. label Apr 15, 2024
Copy link
Contributor

@EmilyV99 EmilyV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Witchybun
Copy link
Contributor

Looks fine to me.

Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mainly shortening things up

@Exempt-Medic Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Apr 19, 2024
@Exempt-Medic
Copy link
Collaborator

Some of these option descriptions have questions marks, which makes them read strangely. Some of them much more than others and there are some periods missing from the end of some sentences, but those are out of scope for this change. The actual changes here seem good to me

@ThePhar ThePhar changed the title Stardew valley: Options page documentation improvements Stardew Valley: Options page documentation improvements Apr 21, 2024
@ThePhar ThePhar merged commit 0624ba5 into ArchipelagoMW:main Apr 21, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: documentation Improvements or additions to documentation. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants