lufia2ac: prevent 0 byte reads #3168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
ScipioWright
added
the
is: bug/fix
Berserker66
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
One of the SRAM reads in the client is implemented using a variable size; that size can be 0.
This doesn't seem to be a problem for luabridge-based emulator connections, which simply return a 0 byte result in that case.
But when such a read command with size 0 is sent to snes9x-nwa it causes an error and a disconnect.
We can avoid this entirely by performing the read only if the size is greater than 0.
How was this tested?
https://discord.com/channels/731205301247803413/1229626698216116265/1229936513299779584