Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factorio: fix client compatibility with Windows 7/Python 3.8 #3196

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Factorio: fix client compatibility with Windows 7/Python 3.8 #3196

merged 1 commit into from
Apr 22, 2024

Conversation

Berserker66
Copy link
Member

What is this fixing or adding?

sets factorio-rcon-py to tested compatible versions

How was this tested?

yes

If this makes graphical changes, please attach screenshots.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Apr 22, 2024
black-sliver
black-sliver approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test but that version worked previously, so should be fine

@Berserker66 Berserker66 merged commit daccb30 into main Apr 22, 2024
17 checks passed
@Berserker66 Berserker66 deleted the factorio_py38_compat branch April 22, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@black-sliver black-sliver black-sliver approved these changes

Assignees
No one assigned
Labels
waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Berserker66 @black-sliver