Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kingdom Hearts: Implement New Game #3201

Open
wants to merge 198 commits into
base: main
Choose a base branch
from
Open

Kingdom Hearts: Implement New Game #3201

wants to merge 198 commits into from
+4,836 −0

Conversation

gaithern
Copy link

What is this fixing or adding?

Adds Kingdom Hearts (EGS PC) as a playable game in AP

How was this tested?

Many test runs in unsupported games, both sync and async.

gaithern and others added 30 commits December 31, 2023 01:32
@gaithern
Initial Commit
0a88fcb
@gaithern
Continued Initial
693b1cd
@gaithern
Bug fixes
c891377
@gaithern
Changed required item in HT
605c4df
@gaithern
Update Rules.py
9fca40e
@gaithern
Update Rules.py
26fd185
@gaithern
Added victory, rules fixes, removed useless items
0ecd694
@gaithern
Changed victory condition, removed EXP Zero
dda4e0c
@gaithern
More Rule fixes, removing wrong items
ef48088
@gaithern
Update Rules.py
961644e
@gaithern
Logic Fixes, Ability Counts
795e7c1
@gaithern
Halloween Town Fire Logic
e6f5d09
@gaithern
Removed unreachable location, logic fixes
7e5cf7d
@gaithern
Many logic fixes
c7d8034
@gaithern
Small changes
424df26
@gaithern
Logic Changes
9130be2
@gaithern
Whoops
d2b7630
@gaithern
Update Rules.py
d1670d5
@gaithern
Logic fixes and invalid level up rewards
7aebfbc
@gaithern
Adding new logic for Hades Cup
5365dd8
@gaithern
Added optional sephiroth win condition
c8e05a8
@gaithern
Update __init__.py
968ed63
@gaithern
Logic changes
c58890b 
Added Atlantica as an optional world
Only require 1 evidence
Only require 1 slide
@gaithern
Update Rules.py
8278bc0
@gaithern
Update Rules.py
b108409
@gaithern
Added Chronicles win condition
ef8ae48
@gaithern
Update Rules.py
f051215
@gaithern
Logic is always fun
24f015a
@Krujo
in dev, item sent message for kh1
5586a0a
@Krujo
probably working sending message
e1a497c
ScipioWright
ScipioWright reviewed May 13, 2024
View reviewed changes
worlds/kh1/Options.py Outdated Show resolved Hide resolved
ScipioWright
ScipioWright reviewed May 18, 2024
View reviewed changes
Copy link
Collaborator

@ScipioWright ScipioWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did another skim, looks generally fine (other than pep8 issues and such). Was doing test gens and found an issue, messaged in discord.

worlds/kh1/__init__.py Outdated Show resolved Hide resolved
worlds/kh1/__init__.py Outdated Show resolved Hide resolved
worlds/kh1/__init__.py Outdated Show resolved Hide resolved
worlds/kh1/__init__.py Outdated Show resolved Hide resolved
worlds/kh1/__init__.py Outdated Show resolved Hide resolved
worlds/kh1/__init__.py Outdated Show resolved Hide resolved
worlds/kh1/Options.py Show resolved Hide resolved
worlds/kh1/Regions.py Outdated Show resolved Hide resolved
@gaithern
Copy link
Author

Implemented all suggestions above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScipioWright ScipioWright ScipioWright requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
is: new game Pull requests for implementing new games into Archipelago. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gaithern @ScipioWright @Krujo