Core: Expose option aliases #3512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: core
hatkirby
added
the
is: enhancement
ScipioWright
approved these changes
Jun 11, 2024
hatkirby
added
waiting-on: core-review
|
what's the use case for this? |
I have a desktop GUI for generating world yamls, similar to what you can do on the WebHost, and it needs access to information about the options each world has available. This allows it to see the aliases an option has so that it can properly parse yaml files that have alias values in them. |
NewSoupVi
approved these changes
Jun 15, 2024
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
GameWyrm
pushed a commit
to GameWyrm/Archipelago-GW
that referenced
this pull request
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
An option's aliases are now stored as an attribute on the option class, for use by a world or tool that may want to see them.
How was this tested?
Wrote some code that looks at an option's aliases field and it was able to successfully retrieve them. pytest still passes.
If this makes graphical changes, please attach screenshots.