Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index: Add a way to sort the index table by column #40

Closed
nodiscc opened this issue Aug 3, 2017 · 5 comments · Fixed by #118
Closed

Index: Add a way to sort the index table by column #40

nodiscc opened this issue Aug 3, 2017 · 5 comments · Fixed by #118

Comments

@nodiscc
Copy link
Contributor

nodiscc commented Aug 3, 2017

Currently, archived items on the index page are sorted by reverse chronological order (most recent first), most likely they are presented in the same order as the original HTML bookmarks export.

It would be nice to be able to sort the table by clicking on each column's header. Eg.

  • Sort items by reverse/chronological order
  • Sort items by title
  • Sort items by original URL

This would probably require a bit of Javascript

@pirate
Copy link
Member

pirate commented Aug 3, 2017

I can sort of see the appeal of chronological order, but what's the use case for sorting by Title/URL?

Not super keen on adding JS either since right now it's pure HTML+CSS.

@nodiscc
Copy link
Contributor Author

nodiscc commented Aug 3, 2017

Sorting by URL would be nice to group articles by website, even if they have been bookmarked months apart. As you said in #41 Ctrl+F works, but is less practical. You can then group pages from the same website together in the list.

Many pages/articles/blog posts have an URL that is relevant to some sorting method, for example:

Sorting by title is not as important.

Not super keen on adding JS either since right now it's pure HTML+CSS.

Enabling JS should be optional and the index page should still work with js disabled (without sorting features though). I'm in favor of using a simple script, not relying on large frameworks like jquery, etc

Edit: examples

@pirate
Copy link
Member

pirate commented Aug 5, 2017

Cool, that's a pretty good use case, I didn't think of that. I'll keep this open until I have some time to hack on it.

@pirate
Copy link
Member

pirate commented Aug 26, 2017

Woah guys I just found this https://github.com/jlord/sheetsee-pocket (DEMO), it looks awesome, and has a bunch of cool features!

I pinged @jlord to see if she's interested in working on bookmark-archiver, but if not I still plan on borrowing some inspiration from her cool index design, including sortable columns and clickable tags.

@jlord
Copy link

jlord commented Aug 29, 2017

Hi @pirate! Sorry about the delay! I don't have any bandwidth to help unfortunately but feel free to take inspiration! ✨

@pirate pirate changed the title Add a way to sort the index table by column Index: Add a way to sort the index table by column Nov 2, 2017
5hay added a commit to 5hay/bookmark-archiver that referenced this issue Dec 1, 2018
The table has advanced features now. One can filter over all columns, sort all
columns asc/desc and paginate the table.
The state (filtered result, current page, sorting order and number of
entries shown) will be saved in localStorage so the user can open the
page in another window or tab and see the same output again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants