Text Search and Filters don't work at the same time in the web UI #1316

[neel-suthar]

Making sure to return distinct results. Changing set operation to '&' to show the matching results from filters AND search term

Fixes: #1316

Summary

The fix involves adjusting the combination of filter and search results to avoid duplicates. Instead of using the "or" (|) operation, consider using a method that ensures the snapshots appearing in the result set satisfy both the filter conditions and the search term. This adjustment aims to eliminate duplicate entries in the combined result.

Before the fix:

After the fix:

Changes these areas

• Bugfixes
• Feature behavior
• Command line interface
• Configuration options
• Internal architecture
• Snapshot data layout on disk

[neel-suthar]

@pirate Please review.

[pirate]

I'm worried that while this enables filters working, it will hide some results that only match via external backend search index but dont match via SQLite db field search (or vice-versa).

e.g. if user searches for some string that's only present in a tag, but not in the snapshot content

Maybe better to extract the filter parameters passed from the UI and apply them to the queryset manually?

[neel-suthar]

Interesting. I thought the search results would contain that information. So when we do perform & operation the final set would have the results matching both. Let me go through the code and figure it out. Thanks.

[pirate]

I merged just the .distinct() fix for now, happy to review other PRs in the future for other changes, though lets discuss them in an issue first to make sure all the use cases are handled :)