Fixes Add button behavior on Safari #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when you clicked the Add button, the page wouldn't change. It looked like it wasn't doing anything, as noted by @rcarmo (ArchiveBox#658 (comment)) I didn't track it down the exact reason why. It may be that Safari didn't like the two opening <h3>s, but I was able to find a bunch of people complaining about Safari being very finicky with innerHTML and actually repainting the page, enough that I decided to try just extending the block hide/show behavior already done with the delay-warning, and it works for me now in both Chrome and Safari. For ArchiveBox#658.
|
Awesome, thanks! |
|
Awesome! If you don't mind, could you add the tag hacktoberfest-accepted?
My kiddos love to wear the shirts as pajamas, go figure :)
…On Sat, Oct 30, 2021, 8:08 PM Nick Sweeting ***@***.***> wrote:
Merged #886 <#886> into dev.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#886 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAIWYPFUT6A3DMR2R2PBNDUJSJHVANCNFSM5G6LCYXQ>
.
|
|
done! @adamwolf |
pirate
added
size: easy
type: bug report
touches: js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, when you clicked the Add button in Safari, the page wouldn't change.
It looked like it wasn't doing anything, as noted by @rcarmo (#658 (comment))
I didn't track it down the exact reason why. It may be that Safari didn't like the two opening
<h3>s, but I was able to find a bunch of people complaining about Safari being very finicky with innerHTML and actually repainting the page, enough that I decided to try just extending the block hide/show behavior already done with the delay-warning, and it works for me now in both Chrome and Safari.Related issues
#658, kinda.
Changes these areas