bot: Limit DELAY_SPEC to 7 digits max.

Prevent accidentally sabotage a job that won't run for a week for example.
ArchiveTeam · Feb 6, 2015 · ae692d8 · ae692d8
1 parent c91df5d
commit ae692d8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/bot/command_patterns.rb b/bot/command_patterns.rb
@@ -1,13 +1,13 @@
 module CommandPatterns
   AC = %r{([^\s]+)(?:\s+(.+))?}
   IDENT = %r{[0-9a-z]+}
-  DELAY_SPEC = %r{[\d]+}
+  DELAY_SPEC = %r{[\d]{1,7}}
 
   ARCHIVE           = %r{\A(?:\!a|\!archive|\!firstworldproblems)(?!\s+<)\s+#{AC}\s*\Z}
   ARCHIVE_FILE      = %r{\A(?:\!a|\!archive|\!firstworldproblems)\s+<\s+#{AC}\s*\Z}
   ARCHIVEONLY       = %r{\A(?:\!ao|\!archiveonly)(?!\s+<)\s+#{AC}\s*\Z}
   ARCHIVEONLY_FILE  = %r{\A(?:\!ao|\!archiveonly)\s+<\s+#{AC}\s*\Z}
-  SET_DELAY         = %r{\A\!d(?:elay)?\s+(#{IDENT})\s+(#{DELAY_SPEC})\s+(#{DELAY_SPEC})}
+  SET_DELAY         = %r{\A\!d(?:elay)?\s+(#{IDENT})\s+(#{DELAY_SPEC})\s+(#{DELAY_SPEC})\s*\Z}
   SET_CONCURRENCY   = %r{\A\!con(?:currency)?\s+(#{IDENT})\s+(\d{1,2})\s*\Z}
   IGNORE            = %r{\A!ig(?:nore)?\s+(#{IDENT})\s+([^\s]+)\s*\Z}
   UNIGNORE          = %r{\A!unig(?:nore)?\s+(#{IDENT})\s+([^\s]+)\s*\Z}

diff --git a/spec/bot/command_patterns_spec.rb b/spec/bot/command_patterns_spec.rb
@@ -191,6 +191,12 @@
 
       md.should be_nil
     end
+
+    it "does not recognize exceedingly large delays" do
+      md = regex.match "#{cmd} f4pg9usx4j96ki3zczwlczu51 0 10000000"
+
+      md.should be_nil
+    end
   end
 
   describe 'Set delay command' do