Fix spurious RsyncUpload failures #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ocmmit is intended to make the ExternalProcess tasks more robust with respect to handling failures. As these tasks represent an external process the only failure cases that really matter are those of the external process. Internal Python errors that occur during the execution of the external process probably don't reflect the actual state of the task/item so they should be ignored while the process continues to run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #48 where an RsyncUpload task will appear to randomly fail leaving an empty directory and causing all retries to fail. The first commit (24c1bf3) is the main fix, ignoring spurious EINTR errors during I/O, with the other two commits attempting to improve the general robustness of error handling surrounding external process tasks.