Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit request timeout #97

Closed
Archomeda opened this issue Aug 16, 2021 · 0 comments · Fixed by #107
Closed

Revisit request timeout #97

Archomeda opened this issue Aug 16, 2021 · 0 comments · Fixed by #107
Labels
Area: Web API v2 Related to the v2 web API Duration: Short Less than 2 hours of estimated work Priority: Medium Medium priority Resolution: Fixed The issue has been fixed Type: Feature An addition to the project

Comments

@Archomeda
Copy link
Owner

Currently the request timeout is determined by a property in the Gw2Sharp.WebApi.Http.HttpClient class. It's not intuitive to change it, because that requires passing a custom instance of the HttpClient to the Connection class, with a different timeout.
It may be more intuitive to have it configurable in the Connection class instead.
@Archomeda Archomeda added Priority: Medium Medium priority Duration: Short Less than 2 hours of estimated work Area: Web API v2 Related to the v2 web API Type: Refactor An improvement to the project that doesn't necessarily add a new features labels Aug 16, 2021
@Archomeda Archomeda mentioned this issue Nov 13, 2021
Merged
@Archomeda Archomeda added Type: Feature An addition to the project and removed Type: Refactor An improvement to the project that doesn't necessarily add a new features labels Nov 13, 2021
@Archomeda Archomeda added the Resolution: Fixed The issue has been fixed label May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Web API v2 Related to the v2 web API Duration: Short Less than 2 hours of estimated work Priority: Medium Medium priority Resolution: Fixed The issue has been fixed Type: Feature An addition to the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make request timeout configurable through IConnection Archomeda/Gw2Sharp
1 participant
@Archomeda