Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added JadeTechModule and PowerCore types for items. #127

Merged
merged 3 commits into from
Feb 28, 2023

Conversation

dlamkins
Copy link
Contributor

@dlamkins dlamkins commented Feb 1, 2023

Several items currently throw an exception when they attempt to deserialize as neither JadeTechModule nor PowerCore are currently listed in the enum.

@dlamkins
Copy link
Contributor Author

dlamkins commented Feb 1, 2023

Silly me. I see there is a lot more to it than just the type. Looking now to see what unique fields these two new types introduce and will update the PR soon enough.

Fixed. 🙂

@Archomeda Archomeda added Type: Feature An addition to the project Area: Web API v2 Related to the v2 web API Type: Bug Something isn't working and removed Type: Feature An addition to the project labels Feb 28, 2023
@Archomeda
Copy link
Owner

This will go together with #128 for preventing exceptions for new item types (and every other castable type). Both this and that PR will fix the issue for the JadeTechModule and PowerCore items, but I'll merge both of them because this PR is also a good setup for extending these types later.

@Archomeda Archomeda merged commit dc10c46 into Archomeda:master Feb 28, 2023
@Archomeda Archomeda mentioned this pull request Mar 12, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Web API v2 Related to the v2 web API Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants