Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reading of the entries in the overview #12

Merged
merged 1 commit into from
Mar 18, 2017

Conversation

dreambottle
Copy link
Contributor

Hopefully, this doesn't break anything else.

@Viir Viir merged commit 01fad6e into Arcitectus:sensor Mar 18, 2017
@Viir
Copy link
Collaborator

Viir commented Mar 18, 2017

Thank you very much, I will publish a release with this so we can get more feedback for this version.

@asdfasdf100500
Copy link

For whatever it is worth:

After running MemoryReadingDemo against Measurement.zip, this fix worked (Entry was not null)
After running actual Sanderling via Visual Studio against Eve, the fix seemed not to work (Entry was null in Overview's ListView)

Maybe there is some DLL linking/caching between Sanderling.Exe and Sanderling.MemoryReading that needs to considered when running the application, but I couldn't get this fix to work in "real life". Or Might totally be just my inexperience with Visual Studio.

@Viir
Copy link
Collaborator

Viir commented Mar 18, 2017

Maybe there is some DLL linking/caching between Sanderling.Exe and Sanderling.MemoryReading that needs to considered when running the application,

To check whether the correct version of the Sanderling.MemoryReading assembly is loaded, you can use the Modules view in Visual Studio while the Debugger is attached to the Sanderling process. This shows you for each loaded module the file path and timestamp, so you can compare to the time you rebuild.

Imgur

@asdfasdf100500
To check whether the application actually uses the local memory reading code, you can place a breakpoint in the changed method. Is this breakpoint hit when a ListView is visible in the eve client?

@dreambottle dreambottle deleted the fix_overview_entries branch November 11, 2018 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants