nx-X11: Add support for riscv64 architecture #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlexGhiti Have you also tested this patch at runtime on RISCV64? Does image byte order / bitmap bit order work correctly in NX based Xserver sessions? (I assume you simply have to launch nxagent -ac :1 and then launch more complex X clients (like a webbrowser) on DISPLAY :1 and see if they render correctly. If you have tested this, please ping me and I'll merge this PR. |
|
This is running epiphany web browser on riscv64 with nxagent installed from @AlexGhiti's PPA: |
sunweaver
force-pushed
the
int/alex/riscv64_support
branch
from
a2ca4e3
to
4605628
Compare
|
@uli42 @AlexGhiti I have also backported this patch to nx-libs in Debian. |
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Nov 5, 2022
RISC-V only support little endian as standard, this patch only adjust settings for riscv64, so it should be pretty much safe to merge in. Also patch already merged by upstream, see more info [1] [1] ArcticaProject/nx-libs#1023 Closes: https://bugs.gentoo.org/879343 Signed-off-by: Xin Yang <yangmame@icloud.com> Signed-off-by: Yixun Lan <dlan@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch (slightly reordered), I was able to build a riscv64 ubuntu package:
https://launchpad.net/~alexghiti/+archive/ubuntu/riscv/+build/22054458
I'm unsure though of what is expected for
LinuxMachineDefinesdefine.