Re-design the nxagent dialog callbacks #387
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunweaver
force-pushed
the
pr/nx-callback-dispatch
branch
from
cff0ac7
to
3d4d9ed
Compare
pkg-config --libs zlib in Debian jessie returns buggy linker parameters. It includes the system's default multi-arch path for shared libs. When linking nxagent, having the system's default shared library path explicitly listed as a "-L" linker option confuses linking against the libXcomp*.so files in the build path. When linking nxagent, we don't want to link against the system's libXcomp*.so files, we want it to get linked explicitly against the just built libXcomp*.so files in nxcomp/ and nxcompshad/. This change assumes that -lzlib is always available in the system's default shared library path.
… components get mentioned first in the nxagent linker command.
…11/exports/lib when linking nxagent. As -L../../exports/lib is already present and points to the same location.
sunweaver
force-pushed
the
pr/nx-callback-dispatch
branch
from
3d4d9ed
to
dfbb4c5
Compare
…cksDispatcher.
- As a starting point for newly implementing a callbacks dispatcher
scenario that allows for capturing various session events and executing
external tools (like dialog boxes, pulldown menus, etc.).
- The callbacks dispatcher approach will finally deprecate the NX_CLIENT
env var related code path in later releases of nxcomp/nxagent.
In the nxagent binary:
For now, the callbacks dispatcher code path is taken if the env var
NX_CALLBACKS_DISPATCHER is set to an application that handles
the dispatching of callbacks from nxagent.
in /usr{/local}/bin/nxagent:
If NX_CALLBACKS_DISPATCHER is an empty string, callbacks are disabled.
If NX_CALLBACKS_DISPATCHER is unset and the dispatcher command
/usr/{local/}{<multiarch>/]nx/bin/nxagent-callbacks-dispatcher cannot be
found, nxagent falls back to its old NX_CLIENT related code path.
…ispatcher exists in the system's PATH, use this script's full path to set NX_CALLBACKS_DISPATCHER env var.
sunweaver
force-pushed
the
pr/nx-callback-dispatch
branch
from
dfbb4c5
to
0922b66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will provide a new and more generic implementation of the NXTransDialog callbacks.
Currently W-i-P...