Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library clean-up: Don't compile (i.e., remove) libNX_Xres.a anymore. #39

Merged
merged 1 commit into from Jun 2, 2015

Conversation

sunweaver
Copy link
Member

The nx-X11/lib/Xres/ code does not get used anywhere in nx-libs.

@sunweaver sunweaver mentioned this pull request May 27, 2015
@sunweaver sunweaver added this to the 3.6.0.x milestone May 27, 2015
@Ionic
Copy link
Member

Ionic commented Jun 1, 2015

Looks good, but one minor thing: debian/rules still references rm -R debian/tmp/usr/include/$(DEB_BUILD_MULTIARCH)/nx/X11/extensions/XRes*.h which is for once removing XResProto.h and previously also XRes.h (which is getting removed by that PR.)

So on Debian, not even the proto header is shipped? I don't know if that was intended from the beginning. It's definitely being used within nx-X11/programs/Xserver.

This is not a problem with your PR, but some general thing I discovered while going through this.

@sunweaver
Copy link
Member Author

@Ionic: I just rebased this branch against 3.6.x.

About the proto file removals in debian/rules. Until now, we only packaged the proto files relevant for the libnx-* packages. The proto files used in the Xserver never got packaged in nx-libs, so far.

Honestly, I would love to avoid the workload of creating dozens of new bin:packages that are likely to be removed again in the long run and not of any use to others.

@Ionic
Copy link
Member

Ionic commented Jun 2, 2015

Yeah, packaging all nxagent protos as individual packages is insane.

@Ionic Ionic merged commit 6a74e67 into ArcticaProject:3.6.x Jun 2, 2015
Ionic added a commit that referenced this pull request Jun 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants