Pr/maximum size #475

uli42 · 2017-07-03T22:42:58Z

Set the limit for maximum screen size to 32767x32767

Please test if this works with your favourite window manager.

sunweaver

uli42: I don't think that the fix you propose here is the right solution to the underlying problem. I am not even sure, if what you saw as a problem really is a problem, or rather the problem.

We need to discuss this further, maybe we need some screen casts, that demonstrate the problem.

sunweaver · 2017-07-10T08:54:23Z

nx-X11/programs/Xserver/randr/rrinfo.c

@@ -81,7 +81,6 @@ RRScanOldConfig(ScreenPtr pScreen, Rotation rotations)
    RRModePtr mode, newMode = NULL;
    int i;
    CARD16 minWidth = MAXSHORT, minHeight = MAXSHORT;
-    CARD16 maxWidth = 0, maxHeight = 0;
    CARD16 width, height;


@uli42: I don't really like it that we have to mess around with code in Xserver/randr/. Can't this be addressed insider the nxagent code itself?

I wonder, if this could be approached differently by looking more deeply at nxagentRandRInitSizes() (in hw/nxagent/Extensions.c) so that we allow for more screen sizes initially. (Just a guess). Also, I wonder why RRGetInfo actually gets called as we have an override function named nxagentRandRGetInfo() (also in Extensions.c).

Good question, need to investigate.

sunweaver · 2017-07-10T09:01:01Z

nx-X11/programs/Xserver/hw/nxagent/Events.c

@@ -639,9 +639,6 @@ void nxagentShadowSwitchResizeMode(ScreenPtr pScreen)
    nxagentShadowCreateMainWindow(screenInfo.screens[DefaultScreen(nxagentDisplay)], screenInfo.screens[0]->root,
                                      screenInfo.screens[0]->root -> drawable.width, screenInfo.screens[0]->root -> drawable.height);

-    sizeHints.max_width = nxagentOption(RootWidth);
-    sizeHints.max_height = nxagentOption(RootHeight);
-


Same here... The WM_NORMAL_HINTS property should always match the current situation of the screen layout, IMHO.

sunweaver · 2017-07-10T09:01:56Z

nx-X11/programs/Xserver/hw/nxagent/Screen.c

-  sizeHints.max_width = WidthOfScreen(DefaultScreenOfDisplay(nxagentDisplay));
-  sizeHints.max_height = HeightOfScreen(DefaultScreenOfDisplay(nxagentDisplay));
+  sizeHints.max_width = MAXSHORT;
+  sizeHints.max_height = MAXSHORT;



Have you actually testing the above code in nxagentShadowAdaptToRatio()?

honestly, no.

uli42 · 2017-07-10T09:42:10Z

For clarification about what this patch addresses: I normally connect from different clients to my long-running session. Some clients have two monitors, some have one, and also the resolutions differ. As long as the initial session start happened on the client with the biggest resolution I have no problems. But if I happen to start (not reconnect!) the session from a "smaller" client that client's resolution is the value that shows up in xrandr. Reconnecting from a "bigger" client leaves me with a session that is not extendable to the full resolution. As I am using fullscreen sessions this leaves me with some black bars of unusable screen estate with no way to do something against it.

Have pushed a new version that is less intrusive and also works if DesktopResizeMode is off

uli42 · 2017-07-12T12:34:36Z

Please review once again

sunweaver

Two more comments...

Also, while at it, shouldn't we add typical resolutions up to 8k here to nxagentRandRInitSizes() right away?

sunweaver · 2017-07-12T18:15:46Z

nx-X11/programs/Xserver/hw/nxagent/Extensions.c

@@ -284,9 +284,9 @@ static int nxagentRandRInitSizes(ScreenPtr pScreen)
                 1024,  768,  900,  900, 1200, 1050, 1080, 1200, 0, 0};
 */
  int w[] = {0, 320, 640, 640, 800, 800, 1024, 1024, 1152, 1280, 1280, 1280, 1360,
-                 1440, 1600, 1600, 1680, 1920, 1920, 0, 0};
+	     1440, 1600, 1600, 1680, 1920, 1920, 32767, 0, 0};


Why not MAXSHORT here instead of 32767?

sunweaver · 2017-07-12T18:15:55Z

nx-X11/programs/Xserver/hw/nxagent/Extensions.c

  int h[] = {0, 240, 360, 480, 480, 600,  600,  768,  864,  720,  800, 1024,  768,
-                  900,  900, 1200, 1050, 1080, 1200, 0, 0};
+	     900,  900, 1200, 1050, 1080, 1200, 32767, 0, 0};


Same here...

MAXSHORT ist better, agreed. We can add some more resolutions but with the new maximum size you can add any resolution on your own.

However: As long as rrxinerama is active your won't ever see those resolutions.

sunweaver · 2017-07-12T19:59:59Z

On Mi 12 Jul 2017 21:23:44 CEST, Ulrich Sibiller wrote: uli42 commented on this pull request. > int h[] = {0, 240, 360, 480, 480, 600, 600, 768, 864, 720, > 800, 1024, 768, - 900, 900, 1200, 1050, 1080, 1200, 0, 0}; + 900, 900, 1200, 1050, 1080, 1200, 32767, 0, 0}; MAXSHORT ist better, agreed. We can add some more resolutions but with the new maximum size you can add any resolution on your own.

Yep.

However: As long as rrxinerama is active your won't ever see those resolutions.

Ok, then leave it as is (except using MAXSHORT) and update your PR branch. Mike -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

sunweaver · 2017-07-12T21:28:19Z

@uli42: please rebase against latest 3.6.x branch, so I can merge.

sunweaver · 2017-08-22T17:33:50Z

@uli42: What is the status of #475? I already approved the merge, but you added more commits without comment. Was that by accident? It feels that some of the newer commits should be part of a second PR.

Please give feedback on your intention for this PR. Thanks!

uli42 · 2017-08-30T19:42:01Z

To answer your question: no, those commits where not by accident, I simply noticed that we need them in the -rrxinerama case.

This patch is working but kind of worthless. It revealed a general problem: with rrxinerama activated (which is the default) modifying screens via xrandr is not really working well due to the fact the the xinerama code will throw away what the user specified on the next move or resize of the nx window. I have not yet come up with a proper idea how to handle that. You can, however, use this code together -rrxinerama.

fixes parts of ArcticaProject#472

Set maximum size to MAXSHORT (32767). This especially helps when reconnecting to a session that had initially been started from a client with a small(er) screen. Before it was impossible to increase the maximum size of a running session beyond the screen size of the client that had initiated the session. This change, together with the previous commit, fixes ArcticaProject#472

place the maximum value directly in the resolution list.

sunweaver · 2018-07-22T14:54:50Z

@Ionic: can you take a second look at that (with my look being the first). I've stumbled over this quite often when switching sessions between machines. Esp. when switching to machines with 4k displays, the size limitation of the previous host is nasty. I'd love to get this changeset in.

uli42 · 2018-07-23T17:23:33Z

sunweaver: so you saw this limitation even with active rrxinerama?

sunweaver · 2018-11-09T15:01:57Z

@uli42: @Ionic: we should get this PR merged over the weekend, IMHO.

sunweaver · 2019-08-27T06:49:48Z

@uli42: @Ionic: this PR #475 has become quite stale but is still an issue in real life cases. I am inclined to rebase and merge it. Thoughts? Vetos?

sunweaver · 2020-01-05T22:28:43Z

What about this one? The maximum size issue is some sort of a problem, indeed. I was about to rebase it, but then spotted the top commit on this branch. Please cleanup (and rebase).

uli42 · 2020-01-05T22:53:47Z

must check - but not today

…

On Sun, Jan 5, 2020 at 11:28 PM Mike Gabriel ***@***.***> wrote: What about this one? The maximum size issue is some sort of a problem, indeed. I was about to rebase it, but then spotted the top commit on this branch. Please cleanup (and rebase). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#475?email_source=notifications&email_token=ABQHBZCCBRORLJM57SK52FDQ4JNJZA5CNFSM4DRS6DC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIEBFNI#issuecomment-570954421>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABQHBZAP3I2YBK4YK57NMQ3Q4JNJZANCNFSM4DRS6DCQ> .

sunweaver · 2020-10-17T20:23:31Z

must check - but not today

Gentle reminder...

uli42 requested review from sunweaver and Ionic July 3, 2017 22:43

uli42 added enhancement work-in-progress labels Jul 3, 2017

sunweaver previously requested changes Jul 10, 2017

View reviewed changes

uli42 force-pushed the pr/maximum_size branch from 603e542 to 8eb3531 Compare July 11, 2017 22:05

sunweaver requested changes Jul 12, 2017

View reviewed changes

uli42 force-pushed the pr/maximum_size branch from 8eb3531 to 28139e7 Compare July 12, 2017 21:04

sunweaver approved these changes Jul 12, 2017

View reviewed changes

uli42 mentioned this pull request Dec 13, 2017

Pr/pre rrxinerama fallback #602

Merged

uli42 added 7 commits December 14, 2017 00:35

set maximum randr resolution to 32767x32767

c6f172b

fixes parts of ArcticaProject#472

preset maximum size

07f583c

place the maximum value directly in the resolution list.

fix compilation warning

8b6e085

extend debugging output

a02938b

set output size in millimeters

85cf09e

some playing around - DO NOT INCLUDE THIS

99cf805

uli42 force-pushed the pr/maximum_size branch from c28fff5 to 99cf805 Compare December 13, 2017 23:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pr/maximum size #475

Pr/maximum size #475

uli42 commented Jul 3, 2017

sunweaver left a comment

sunweaver Jul 10, 2017

uli42 Jul 10, 2017

sunweaver Jul 10, 2017

sunweaver Jul 10, 2017

uli42 Jul 10, 2017

uli42 commented Jul 10, 2017

uli42 commented Jul 12, 2017

sunweaver left a comment

sunweaver Jul 12, 2017

sunweaver Jul 12, 2017

uli42 Jul 12, 2017

sunweaver commented Jul 12, 2017 via email

sunweaver commented Jul 12, 2017

sunweaver commented Aug 22, 2017

uli42 commented Aug 30, 2017

sunweaver commented Jul 22, 2018

uli42 commented Jul 23, 2018

sunweaver commented Nov 9, 2018

sunweaver commented Aug 27, 2019

sunweaver commented Jan 5, 2020

uli42 commented Jan 5, 2020 via email

sunweaver commented Oct 17, 2020

Pr/maximum size #475

Are you sure you want to change the base?

Pr/maximum size #475

Conversation

uli42 commented Jul 3, 2017

sunweaver left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

uli42 commented Jul 10, 2017

uli42 commented Jul 12, 2017

sunweaver left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sunweaver commented Jul 12, 2017 via email

sunweaver commented Jul 12, 2017

sunweaver commented Aug 22, 2017

uli42 commented Aug 30, 2017

sunweaver commented Jul 22, 2018

uli42 commented Jul 23, 2018

sunweaver commented Nov 9, 2018

sunweaver commented Aug 27, 2019

sunweaver commented Jan 5, 2020

uli42 commented Jan 5, 2020 via email

sunweaver commented Oct 17, 2020