Fix FTBFS on non-ELF platforms. #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…make conditional if target compiler is generating ELF binaries.
…if target system actually is ELF-based.
…target system actually is ELF-based. Fixes: ArcticaProject#661
sunweaver
approved these changes
Feb 25, 2018
uli42
added a commit
to uli42/nx-libs
that referenced
this pull request
Dec 11, 2019
Fixes ArcticaProject#663 The previous logic was completely broken as it depended on the order of atoms being created on the real X server. This might have been working in the beginning of NX but eventually atom mapping between nxagent and the real X server was introduced which broke the whole logic. As a rather ugly fix let's not create the NX_IDENTITY and NX_AGENT_SIGNATURE atoms to the real X server. If we find them nevertheless on the remote side we are running nested. This change is neither nice nor efficient, just functional. It should be redesigned one day.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if target system is ELF-based and only add flag that enables new ELF dtags on ELF-based target systems.
Fixes: #661