Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Icons for Single App. (Based on System Theme) #1753

Closed
BaruaAtish opened this issue Oct 20, 2023 · 8 comments
Closed

Multiple Icons for Single App. (Based on System Theme) #1753

BaruaAtish opened this issue Oct 20, 2023 · 8 comments

Comments

@BaruaAtish
Copy link

Hello, I want to help contribute to Arcticons by submitting icons I create for an app called "DualWallpaper". The issue is, DualWallpaper changes icons based on system theme. I have created icons for both versions but do not know how to name and add them to the others folder and how to list them in the xml. Any help would be appreciated. Thank you!

@BaruaAtish
Copy link
Author

Relevant Images for context:
icon_day
icon_night
DualWallpaperNight
DualBackGroundSun

@Donnnno
Copy link
Collaborator

Donnnno commented Oct 20, 2023

Hmm do they have different appfilter activities?

@BaruaAtish
Copy link
Author

BaruaAtish commented Oct 20, 2023

I don't think so, this is the info I got from the last time I made a request for this, the action was the same back then too:

<!-- DualWallpaper -->
<item component="ComponentInfo{de.dlyt.yanndroid.dualwallpaper/de.dlyt.yanndroid.dualwallpaper.ui.activity.MainActivity}" drawable="dualwallpaper"/>
https://play.google.com/store/apps/details?id=de.dlyt.yanndroid.dualwallpaper
https://f-droid.org/en/packages/de.dlyt.yanndroid.dualwallpaper/
Requested 1 times
Last requested 1682961086.0

@Donnnno
Copy link
Collaborator

Donnnno commented Oct 20, 2023

Have you tried getting it with Icon Request? https://github.com/Kaiserdragon2/IconRequest/releases

Maybe it's different when you change the mode; otherwise, automatic switching isn't possible.

We can still add both tho!

@BaruaAtish
Copy link
Author

BaruaAtish commented Oct 20, 2023

I tried and it showed the same thing.

de.dlyt.yanndroid.dualwallpaper
de.dlyt.yanndroid.dualwallpaper.ui.activity.MainActivity

I'm going to try using it both in light and dark mode to see if it makes a difference then sometime today, just to make sure.

Edit: Heres the git to the app if it helps find something I don't know about

https://github.com/Yanndroid/DualWallpaper

@Kaiserdragon2
Copy link
Collaborator

I have tested it out and it is possible to do as you can see with the following debug apk.
Debug-apk.zip
But the current setup doesn't allow for this kind of build and there need to be some file manually moved and renamed.
I don't know if it is worth to change the script to allow for such builds.

@TotallyAvailable
Copy link
Contributor

Slightly off topic but with more apps jumping onto the custom Icon (behind a paywall) train, how are you/we going to move forward ?

  • Cover every (Icon assigned)Activity with the same default Icon from the host app to avoid "breakage/app not covered/please fix!"
  • Leave them be for now and let them flood the Icon Request backlog
  • Cover them with the default Icon and replace on demand as individual requests/contributions come in
  • Don't bother until things get out of control

@Donnnno
Copy link
Collaborator

Donnnno commented Jan 23, 2024

As far as I know, this is only possible when the dev uses different activities for the icons. If not, it's not possible for the icon pack to switch between icons.

@Donnnno Donnnno closed this as completed Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants