-
-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arcicons day night #1838
Arcicons day night #1838
Conversation
xml files are created at build time
This is sick, gonna take a good look at everything later! It was on my to-do list for a while, but you've beat me to it 😅 great work!!! |
All the drawables are added to gitignore, why exactly? |
These are recreated at build time from the svgs at each build. |
quick question, how does it knows how to make all icons then? do you have some sort of documentation how to test this? |
If you open the project in Android studio you will see a new module in the project overview there lays the program that converts the svgs to xml. The program simply converts all svgs in the white folder to xml and uses the android studio built in converter. In the gradle file for the app it is defined which parameters are used to invoke the module for each flavor. If you click build you will get the output of the conversion in the drawable-anydpi folder. |
oh that's awesome! |
Just tested it, and wow the android studio icon generation is awesome! The icon pack is very cool like that too, although some launchers have trouble with changing it so quickly (or it's just my Samsung phone) I've removed the Google Play build option because Google would definitely remove the apps again, if I'm gonna release that version there 😅 Also gonna have to create some graphics soon :) Fantastic work :))) |
Todo:
|
Does make me wonder why the option to select 2 or potentially more icon packs linked to certain trigger conditions isn't more common. The launcher reloading all icons independently instead of all at once would make things also somewhat less annoying. Should also solve #1753 and potentially play into #1772 Note for later as it is actually causing quite a few problems currently
|
Noticed that all the You drawables are removed, just to be sure, does it generate the clock and widgets as well? Edit: Never mind, they were in a different folder 🙃 |
Hoping to merge this before the holidays, btw! |
Co-Authored-By: Bastian <8929967+Kaiserdragon2@users.noreply.github.com>
I think we're ready :) |
Might need some new launcher icon and some other graphical changes