Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arcicons day night #1838

Merged
merged 26 commits into from
Dec 23, 2023
Merged

Conversation

Kaiserdragon2
Copy link
Collaborator

@Kaiserdragon2 Kaiserdragon2 commented Nov 25, 2023

Might need some new launcher icon and some other graphical changes

@Kaiserdragon2 Kaiserdragon2 marked this pull request as ready for review November 25, 2023 21:34
@Donnnno
Copy link
Collaborator

Donnnno commented Nov 25, 2023

This is sick, gonna take a good look at everything later!

It was on my to-do list for a while, but you've beat me to it 😅 great work!!!

@Donnnno
Copy link
Collaborator

Donnnno commented Nov 29, 2023

All the drawables are added to gitignore, why exactly?

@Kaiserdragon2
Copy link
Collaborator Author

These are recreated at build time from the svgs at each build.

@Donnnno
Copy link
Collaborator

Donnnno commented Nov 30, 2023

quick question, how does it knows how to make all icons then?

do you have some sort of documentation how to test this?

@Kaiserdragon2
Copy link
Collaborator Author

Kaiserdragon2 commented Nov 30, 2023

If you open the project in Android studio you will see a new module in the project overview there lays the program that converts the svgs to xml. The program simply converts all svgs in the white folder to xml and uses the android studio built in converter. In the gradle file for the app it is defined which parameters are used to invoke the module for each flavor. If you click build you will get the output of the conversion in the drawable-anydpi folder.

@Donnnno
Copy link
Collaborator

Donnnno commented Nov 30, 2023

oh that's awesome!

@Donnnno
Copy link
Collaborator

Donnnno commented Dec 15, 2023

Just tested it, and wow the android studio icon generation is awesome!

The icon pack is very cool like that too, although some launchers have trouble with changing it so quickly (or it's just my Samsung phone)

I've removed the Google Play build option because Google would definitely remove the apps again, if I'm gonna release that version there 😅

Also gonna have to create some graphics soon :)

Fantastic work :)))

@Donnnno
Copy link
Collaborator

Donnnno commented Dec 15, 2023

Todo:

  • Store listings
  • Graphics
  • app icon
  • Theming tweaks?

@Donnnno Donnnno added enhancement New feature or request black/white labels Dec 15, 2023
@TotallyAvailable
Copy link
Contributor

TotallyAvailable commented Dec 15, 2023

Does make me wonder why the option to select 2 or potentially more icon packs linked to certain trigger conditions isn't more common. The launcher reloading all icons independently instead of all at once would make things also somewhat less annoying.

Should also solve #1753 and potentially play into #1772

Note for later as it is actually causing quite a few problems currently

Android documentation [1] explicity specify that adaptive icons must be
108x108dp.
Having bigger Adaptive icons triggers a bug in Android 14 QPR1 that
prevent to install apps from apk directly when the icons are bigger.

[1] https://developer.android.com/develop/ui/views/launch/icon_design_adaptive

@Donnnno
Copy link
Collaborator

Donnnno commented Dec 22, 2023

Noticed that all the You drawables are removed, just to be sure, does it generate the clock and widgets as well?

Edit: Never mind, they were in a different folder 🙃

@Donnnno
Copy link
Collaborator

Donnnno commented Dec 22, 2023

Hoping to merge this before the holidays, btw!

Donnnno and others added 4 commits December 22, 2023 21:55
Co-Authored-By: Bastian <8929967+Kaiserdragon2@users.noreply.github.com>
@Donnnno
Copy link
Collaborator

Donnnno commented Dec 23, 2023

I think we're ready :)

@Donnnno Donnnno merged commit bc729a2 into Arcticons-Team:main Dec 23, 2023
@Kaiserdragon2 Kaiserdragon2 deleted the ArciconsDayNight branch February 13, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
black/white enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants