Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icons print, dropbox and signal are faulty #1794

Closed
quantenzitrone opened this issue Nov 13, 2023 · 2 comments · Fixed by #1795
Closed

icons print, dropbox and signal are faulty #1794

quantenzitrone opened this issue Nov 13, 2023 · 2 comments · Fixed by #1795

Comments

@quantenzitrone
Copy link
Contributor

quantenzitrone commented Nov 13, 2023 •
edited

print.svg has this weird edge
image

signal.svg has sharp edges except for one
image

dropbox.svg has stroke-linecap:round;stroke-linejoin:round missing resulting in sharp edges
@quantenzitrone quantenzitrone changed the title print and dropbox are faulty icons print, dropbox and signal are faulty Nov 13, 2023
quantenzitrone added a commit to quantenzitrone/Arcticons that referenced this issue Nov 13, 2023
@quantenzitrone
fix Arcticons-Team#1794: errors in dropbox print and signal icons
4a9e7de
@quantenzitrone quantenzitrone mentioned this issue Nov 13, 2023
Merged
@Donnnno
Copy link
Collaborator

Donnnno commented Nov 14, 2023

The signal icon was probably the only icon that I've allowed to have a sharp edge. The one rounded edge feels like a rendering error, tho.

@quantenzitrone
Copy link
Contributor Author

the thingy the rounded edge is on is a loop
(stroke-linejoin:round makes it round)
the loop also results in the stroke being a bit thicker in the middle

Donnnno added a commit that referenced this issue Nov 17, 2023
@Donnnno
Merge pull request #1795 from quantenzitrone/main
f482bff 
fix #1794: errors in dropbox print and signal icons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #1794: errors in dropbox print and signal icons quantenzitrone/Arcticons
2 participants
@Donnnno @quantenzitrone