Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daylight reproducible build failed #1952

Closed
linsui opened this issue Jan 26, 2024 · 14 comments
Closed

daylight reproducible build failed #1952

linsui opened this issue Jan 26, 2024 · 14 comments

Comments

@linsui
Copy link

linsui commented Jan 26, 2024

res/zIP.xml is missing in our build. Could you please take a look? Thanks!

@Donnnno
Copy link
Collaborator

Donnnno commented Jan 26, 2024

zIP.xml, never seen that one before

I'll take a look at it later

@petlyh
Copy link
Contributor

petlyh commented Feb 1, 2024

I took a look at it myself. It looks like the daynight and you APKs in your GitHub release includes foodora_dk.xml, which is not in the F-Droid builds since the foodora_dk icon doesn't exist in the repo after 2cd600b. zIP.xml is just the scrambled filename for that file, so this accounts for that difference. I also checked some of the files that differed and it looks like the only differences are the references that are auto-generated at build-time, which have probably just been offset by there being an extra file.

Diff of one of the files:

@Donnnno
Copy link
Collaborator

Donnnno commented Feb 3, 2024

Found it! @petlyh to the rescue :) Thanks a lot!

@Donnnno
Copy link
Collaborator

Donnnno commented Feb 4, 2024

Just pushed a new release, hopefully it should be fixed now :)

@linsui
Copy link
Author

linsui commented Feb 4, 2024

diff.html.zip
Looks like other flavor is not reproducible, either.

@Donnnno
Copy link
Collaborator

Donnnno commented Feb 4, 2024

Hmm, very strange. @Kaiserdragon2 might this have something to do with recent changes to the preparerelease script & builder things?

@Kaiserdragon2
Copy link
Collaborator

yeah somehow some drawables aren't included in the drawable.xml for the fdroid build if i interpret the diff correctly. Normally every build should result in the same output.

@Kaiserdragon2
Copy link
Collaborator

i just build it (normal) and compared to the apk on github and i get the same output except the certs (thats expected)

@Donnnno
Copy link
Collaborator

Donnnno commented Feb 4, 2024

i just build it (normal) and compared to the apk on github and i get the same output except the certs (thats expected)

Is it possible it might be an F-Droid error?

@Kaiserdragon2
Copy link
Collaborator

Kaiserdragon2 commented Feb 4, 2024

Just build it on a linux machine and i get the same differnces (don't know why)
i forgot to sort a category and windows sorts different then linux working on a fix

@Kaiserdragon2
Copy link
Collaborator

i just build it (normal) and compared to the apk on github and i get the same output except the certs (thats expected)

Is it possible it might be an F-Droid error?

More like my error some missing lines of code

@Donnnno
Copy link
Collaborator

Donnnno commented Feb 4, 2024

Just in time! Thanks for the fix, otherwise we had to wait another week

@Donnnno
Copy link
Collaborator

Donnnno commented Feb 4, 2024

@linsui
Copy link
Author

linsui commented Feb 5, 2024

It works, thanks!

@linsui linsui closed this as completed Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants