Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update & Extend Coverage #1786

Merged
merged 9 commits into from
Nov 11, 2023
Merged

Update & Extend Coverage #1786

merged 9 commits into from
Nov 11, 2023

Conversation

TotallyAvailable
Copy link
Contributor

@TotallyAvailable TotallyAvailable commented Nov 9, 2023

  • Root Version of the App (Same Dev)
  • Hanping Pro + Cantonese Version (Same Icon)
  • Andoku 2 & 3 existing Sudoku Icon
  • Super Image Paid Version
  • existing Icon for Insomnia
  • 2 more Kustom Apps joining the family
  • existing Icon for Now in Android (close enough ?)
  • Generic Android Icon for Captive Portal & Orange
  • existing for IPWidget (purely personal taste)
  • existing for Classic Power Menu + Digital Detox (Power Button...)
  • existing for NekoSMS (LSPosed module to filter, you guessed it, SMS)

Obviously feel free to reject, change or suggest changes if some additions get to "personal"/repetitive.

(I'll get more descriptive with the commits at some point...promise!)

Signed-off-by: TotallyAvailable <150343468+TotallyAvailable@users.noreply.github.com>
Signed-off-by: TotallyAvailable <150343468+TotallyAvailable@users.noreply.github.com>
Signed-off-by: TotallyAvailable <150343468+TotallyAvailable@users.noreply.github.com>
Signed-off-by: TotallyAvailable <150343468+TotallyAvailable@users.noreply.github.com>
@Donnnno
Copy link
Collaborator

Donnnno commented Nov 9, 2023

Nice! Great to see that you're managing your way with the appfilter. :-)

@TotallyAvailable
Copy link
Contributor Author

TotallyAvailable commented Nov 9, 2023

Sneaky edit and on topic side-note, it appears the changelog-after-update pop-up does indeed work, every time the app is opened apparently. (As I totally didn't check back more than once during the commits)

I might even start cleaning up after myself at some point (probably a few obsolete App Request Entries already) but you know, slow and steady.

The mentioned concern is just a result of only touching Apps in personal use so far -> stuff I would've (and did) requested in the past....after playing around with MicoPacks (and Iconeration), might as well be part of helping Arcticons towards 100% coverage.
...
Kinda off(pull-request)topic but besides being as creatively blessed as ...a rock, there's more to come.

Signed-off-by: TotallyAvailable <150343468+TotallyAvailable@users.noreply.github.com>
@TotallyAvailable
Copy link
Contributor Author

Another set of 7 using existing Icons, the names kinda paint the whole picture already so I'll skip the essay this time around.

'Manager-less variant of LSPosed + Root Version of Shizuku.
Decided to end the piggybacking with a separate 'Sui' entry, still using an existing Icon.

Does either work ? Maybe...maybe not.
As neither should be present on the majority of devices it might not break anything either...Google might not like it for the Play Store Version though.

Assigning mentioned Icons manually to mentioned Activities does work and stick through reboots & updates fine.
Icon choice purely personal choice. Kinda prefer 'xposed_alt' over 'LSPosed' though.

Signed-off-by: TotallyAvailable <150343468+TotallyAvailable@users.noreply.github.com>
@TotallyAvailable
Copy link
Contributor Author

TotallyAvailable commented Nov 10, 2023

One more goodie for now.
Bit more "controversial" or rather experimental, maybe.
Attached Note should clarify the thoughts behind it.

Might be a total 💩 commit or a 💎 for any future Root User...someone might've already tried/requested the inclusion... literally went in blind on that one 👍
(The shell entry certainly won't work like that anyway as I figured out later...'[Package name]/android.app.AppDetailsActivity')

Signed-off-by: TotallyAvailable <150343468+TotallyAvailable@users.noreply.github.com>
Signed-off-by: TotallyAvailable <150343468+TotallyAvailable@users.noreply.github.com>
@TotallyAvailable
Copy link
Contributor Author

Maybe fix #1783 (quick'n'dirty taken from the OG commit in 2021)
Is it going to be this easy ? Does the original file still exist in the current build ? Is adding "_og" the way to go ? maybe, maybe not

Might be time for some more consolidated commits in a separate branch though (which existed and almost messed this request up before my brain woke up apparently... 🤦)

Signed-off-by: TotallyAvailable <150343468+TotallyAvailable@users.noreply.github.com>
@TotallyAvailable
Copy link
Contributor Author

Still in conflict with just "piggybacking" existing entries while covering more stuff with existing icons vs dedicated AppNamed entries referring to existing icons as I keep scrolling past both ways being used.

Given that Auto apply and Launcher suggested don't care, it'll still leave someone out there searching for it to manually assign it to something in disappointment, assuming the 'donor' app isn't installed as well. (Totally been there before ofc)
Might obviously be kinda irrelevant as I'm going to run out of 'cover-by-existing' pretty soon anyway...assuming (big if true) I proceed to new Icon contributions, that's new entries anyway.

@Donnnno
Copy link
Collaborator

Donnnno commented Nov 11, 2023

You're giving me a lot of thoughts, but your commit looks good like this!

@Donnnno Donnnno merged commit b306474 into Arcticons-Team:main Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants