Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hero image replacement #69

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

hero image replacement #69

wants to merge 3 commits into from
+10 −10

Conversation

elite0226
Copy link
Contributor

No description provided.

@elite0226 elite0226 requested a review from toastal April 5, 2022 23:04
@elite0226 elite0226 requested a review from CSVdB as a code owner April 5, 2022 23:04
toastal
toastal reviewed Apr 6, 2022
View reviewed changes
Copy link
Contributor

@toastal toastal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, but we're running into the same also load a WebP and AVIF files because PNG isn't optimal here.

@elite0226
Copy link
Contributor Author

After finish the refactoring Orbis website with ejs, we will have to refactor Ardana Landing page also.
I know the images are not optimized and there are some stuffs needs to be improved or fixed.

This PR is just for avoid background video not working.

toastal
toastal suggested changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@toastal toastal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of fully removing the dependency. If you recall, they were injecting scripts at run time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toastal toastal toastal requested changes

@CSVdB CSVdB Awaiting requested review from CSVdB

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elite0226 @toastal