Merge branch 'main' of https://github.com/ArdenButterfield/Maim

oops

Docs/BUILDING.md

@@ -0,0 +1,128 @@
+# Building Maim
+
+The Maim build process, especially on Windows, is one that could be charitably described as "nontrivial." 
+We figured out the steps, so you don't have to.
+
+## Linux
+
+### Prerequisites:
+* [CMake version >= 3.24.1](https://cmake.org/download/) (This link actually takes you to the latest version)
+* ninja
+* ccache (Ensure that ccache is actually on the path: `which g++ gcc` should return `/usr/lib/ccache/g++ /usr/lib/ccache/gcc`.)
+
+### Steps:
+
+1. Clone the repository, making sure to use `--recurse-submodules` to clone JUCE as well.
+
+```sh
+git clone --recurse-submodules https://github.com/ArdenButterfield/Maim
+```
+
+2. Build Lame. This project includes a quirked up version of [LAME](https://lame.sourceforge.io/), 
+3. so even if you have LAME installed already, you still need to do this step.
+
+```sh
+cd Fish/Source/lib/lame/
+./configure CFLAGS="-fPIC"  --disable-frontend --enable-expopt=full --disable-shared --enable-static
+make
+cd ../../..
+```
+
+3. Build the plugin. You can change `Release` to `Debug` in both lines to change the build configuration to one without optimization.
+
+```sh
+cmake -B Builds -G Ninja -DLAME_LIB=Source/lib/lame/libmp3lame/.libs/libmp3lame.a -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -DCMAKE_OSX_ARCHITECTURES="arm64;x86_64"
+cmake --build Builds --config Release
+```
+
+Now, you should find `Maim.vst3` inside `~/.vst3`, where it will be discoverable by any digital audio workstation.
+
+## Mac
+
+The steps to build on Mac are very similar to building on Linux. 
+Note that the configure command when building Lame is slightly different from in the Linux instructions.
+
+### Prerequisites:
+* [CMake version >= 3.24.1](https://cmake.org/download/) (This link actually takes you to the latest version)
+* ninja
+* ccache (Ensure that ccache is actually on the path: `which g++ gcc` should return `/usr/local/opt/ccache/libexec/g++ /usr/local/opt/ccache/libexec/gcc
+  `, or something similar.)
+
+### Steps:
+
+1. Clone the repository, making sure to use `--recurse-submodules` to clone JUCE as well.
+
+```sh
+git clone --recurse-submodules https://github.com/ArdenButterfield/Maim
+```
+
+2. Build Lame. This project includes a quirked up version of [LAME](https://lame.sourceforge.io/), so even if you have LAME installed already, you still need to do this step.
+
+```sh
+cd Maim/Source/lib/lame/
+./configure CFLAGS="-arch x86_64 -arch arm64 -fPIC"  --disable-frontend --enable-expopt=full --disable-shared --enable-static
+make
+cd ../../..
+```
+
+3. Build the plugin. You can change `Release` to `Debug` in both lines to change the build configuration to one without optimization.
+
+```sh
+cmake -B Builds -G Ninja -DLAME_LIB=Source/lib/lame/libmp3lame/.libs/libmp3lame.a -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -DCMAKE_OSX_ARCHITECTURES="arm64;x86_64"
+cmake --build Builds --config Release
+```
+
+Now, you should find `Maim.vst3` inside `~/Library/Audio/Plugins/VST3` and `Maim.component` inside `~/Library/Audio/Plug-Ins/Components`, where it will be discoverable by any digital audio workstation.
+
+## Windows
+
+### Prerequisites:
+* [CMake version >= 3.24.1](https://cmake.org/download/) (This link actually takes you to the latest version)
+* [JetBrains CLion IDE](https://www.jetbrains.com/clion/) (Or not if you like your CMake builds raw)
+* [Build Tools for Visual Studio 2022](https://aka.ms/vs/17/release/vs_BuildTools.exe) (The build tools may or may not just come with regular Visual Studio) (If you don't have this, consider being visited by the magic binary distributor fairy)
+* [Intel IPP](https://www.intel.com/content/www/us/en/developer/tools/oneapi/ipp.html) (I don't have a joke for this one)
+
+### Steps:
+
+1. Go through the Intel IPP installer. Or, just run the following:
+
+```
+curl --output oneapi.exe https://registrationcenter-download.intel.com/akdlm/irc_nas/19078/w_BaseKit_p_2023.0.0.25940_offline.exe
+./oneapi.exe -s -x -f oneapi
+./oneapi/bootstrapper.exe -s -c --action install --components=intel.oneapi.win.ipp.devel --eula=accept -p=NEED_VS2022_INTEGRATION=1 --log-dir=.
+```
+
+2. Clone the repo with `git clone --recurse-submodules https://github.com/ArdenButterfield/Maim` (Recursive to make sure git clone also hits JUCE).
+
+3. Inside your local project, navigate to `Source/lib/lame`. (This is a quirked up version of [LAME](https://lame.sourceforge.io/) included in the project, so even if you have LAME already installed, you still need to do this step.)
+
+4. Copy the file called `configMS.h` into `libmp3lame/config.h` (you would presumably copy one of the other config files if you were on a different OS).
+
+5. Launch the command window `x64 Native Tools Command Prompt for VS 2022` which you can find from the start menu if you have Build Tools for Visual Studio 2022 installed.
+
+6. Inside the command window, run `cd [Path to root directotry of local project]/Source/lib/lame`.
+
+7. Then run `nmake dll -f Makefile.MSVC comp=msvc asm=n`.
+
+8. Hopefully the build should succeed, and you can now see the built file `Source/lib/lame/output/libmp3lame-static.lib`.
+
+9. Before we open up the project in CLion, there's even more hoops we need to jump through. (Isn't that what you wanted to hear?) CLion must be run with administrator privileges to install the VST file correctly. If you installed CLion yourself, then you can probably right-click, "Run as Administrator". If you installed CLion through JetBrains Toolbox, click on the vertical dots next to CLion in the list, click "Settings" in the dropdown, the click on "Configuration". Toggle "Run as administrator".
+
+10. Open up the project in CLion. It's gonna start trying to load the CMake project and there's going to be errors because we need to change the CMake settings first.
+
+11. Go to `File | Settings | Build, Execution, Deployment | CMake`. In the `CMake options:` field, place in `-DLAME_LIB=Source\lib\lame\output\libmp3lame-static.lib`, the path to our built file.
+
+12. Now reload the CMake project.
+
+13. CLion should detect a bunch of CMake Application Run Configurations. Select the one called `Maim_VST3`. You may have to edit the configuration and set the `Executable:` as `Tests`.
+
+14. Also when editing the configuration, check "Run with Administrator privileges". Otherwise we're gonna get a permissions denied build error.
+
+
+15. Run `Maim_VST3`.
+
+16. After taking 12 years to build, the built plugin should be placed into `C:\Program Files\Common Files\VST3\Maim.vst3\Contents\x86_64-win\Maim.vst3`. It is now ready to be used wherever you want.
+
+### Notes:
+
+* If the build fails and you get a message like `file INSTALL cannot set permissions on "C:\Program Files\Common File/VSt3/Maim.vst3": Permission denied.`, it might be for two reasons. The first is that you didn't follow my instructions on giving the build adminsitrator privileges. The second is because your audio workstation is currently using the previously built VST file. You have to close it to rebuild.

README.md

@@ -2,12 +2,21 @@
 
 *MAIM Ain't an Implementation of Mp3*
 
-MAIM is an audio plugin that circuit bends an MP3 encoder in real time, disrupting the control flow sending data down unexpected paths to create digital distortions. 
+MAIM is an audio plugin that circuit bends an MP3 encoder in real time, 
+disrupting the control flow sending data down unexpected paths to create digital distortions. 
 
-This plugin is still very much a work in progress, and is changing rapidly, so there are no guarantees that it works at any point in time. That said, feel free to give the code a try, and raise an issue or make a pull request if you have any suggestions!
+## Installation Instructions
 
-## Building and Installation
+Under the releases tab from the Github, download the installer corresponding to your operating system.
 
+On Windows or Mac, follow the instructions in the installer to install the plugin to your plugins folder.
+
+On Linux, you'll have to copy Maim.vst3 to your plugin folder. Often this is at ~/.vst3, 
+but if you're making music on Linux you're probably already a step ahead of me.
+
+If you have any issues, please raise an issue on the issues page of this repository and describe your situation.
+
+If instead you wish to build the plugin yourself, see the [build instructions](Docs/BUILDING.md).
 To build MAIM, first build the LAME library. This step is necessary even if you have LAME installed on your machine, as MAIM uses a modified version of LAME. To do this, run the following commands:
 
 ```sh

Source/GUIelements/PsychoanalGraph.cpp

@@ -53,7 +53,6 @@ void PsychoanalGraph::valueTreePropertyChanged(juce::ValueTree &treeWhosePropert
         }
     } else if (property == juce::Identifier("threshold")) {
         juce::Array<juce::var>* t = treeWhosePropertyHasChanged[property].getArray();
-        std::cout << "new threshold";
         for (int i = 0; i < 22; ++i) {
             thresholdVals[i] = (float)(*t)[i].operator double();
         }

Source/GUIelements/TitlePanel.cpp

@@ -27,7 +27,7 @@ void TitlePanel::paint (juce::Graphics& g)
     g.drawText ("MAIM", textRect,
         juce::Justification::centredLeft, true);
     g.setFont(tooltip_font);
-    g.drawText("Version 0.0.1", textRect.withTrimmedBottom(10).withTrimmedLeft(2), juce::Justification::bottomLeft, true);
+    g.drawText("Version 1.0.0alpha", textRect.withTrimmedBottom(10).withTrimmedLeft(2), juce::Justification::bottomLeft, true);
 }
 
 void TitlePanel::resized()

VERSION

@@ -1 +1 @@
-0.0.1
+1.0.0