Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: implement twMerge #191

Merged
merged 4 commits into from
Mar 22, 2024
Merged

refactor: implement twMerge #191

merged 4 commits into from
Mar 22, 2024

Conversation

patricio0312rev
Copy link
Contributor

[extension] implement twMerge

Summary

  • twMerge has been implement for components where there could be overlay between tailwind class names. (Basically reusable components with className prop, since other components have their class names predefined or just use cn for its variations)

Checklist

  • I checked that both pnpm dev and pnpm dev:bare work as intended
  • I checked the basic extension interactions and made sure wallet selection works
  • I checked my UI changes against the design and there are no notable differences, including responsiveness
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • Ready to be merged

@ItsANameToo ItsANameToo added this to the 1.7.0 milestone Mar 22, 2024
@ItsANameToo ItsANameToo merged commit ba7cae3 into develop Mar 22, 2024
4 checks passed
@ItsANameToo ItsANameToo deleted the refactor/use-of-tw-merge branch March 22, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants