Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tooltips in Ledger approval page #196

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

patricio0312rev
Copy link
Contributor

[extension] tooltip not working on Ledger approval page

Summary

  • ActionDetailsValue component has been refactored. It now forwards the ref from the tooltips in case it is a child component.
  • Tooltips are now being correctly rendered in Ledger approval pages.
image

Checklist

  • I checked that both pnpm dev and pnpm dev:bare work as intended
  • I checked the basic extension interactions and made sure wallet selection works
  • I checked my UI changes against the design and there are no notable differences, including responsiveness
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • Ready to be merged

@ItsANameToo ItsANameToo merged commit 6ada327 into develop Mar 25, 2024
4 checks passed
@ItsANameToo ItsANameToo deleted the fix/tooltips-in-ledger-approval-page branch March 25, 2024 13:49
@ItsANameToo ItsANameToo added this to the 1.7.0 milestone Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants