Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add transaction pending state #201

Merged
merged 10 commits into from
Mar 28, 2024
Merged

feat: add transaction pending state #201

merged 10 commits into from
Mar 28, 2024

Conversation

shahin-hq
Copy link
Contributor

@shahin-hq shahin-hq commented Mar 27, 2024 •
edited

Summary

Closes: https://app.clickup.com/t/86drqgud1
Design: https://www.figma.com/file/GCqNSpm379nEO9IEHQl2dt/ARK-Connect?node-id=9623%3A25026&mode=dev

Checklist

  • I checked that both pnpm dev and pnpm dev:bare work as intended
  • I checked the basic extension interactions and made sure wallet selection works
  • I checked my UI changes against the design and there are no notable differences, including responsiveness
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • Ready to be merged

@ItsANameToo ItsANameToo marked this pull request as draft March 28, 2024 10:25
@shahin-hq shahin-hq marked this pull request as ready for review March 28, 2024 12:21
ItsANameToo
ItsANameToo requested changes Mar 28, 2024
View reviewed changes
src/pages/VoteApproved.tsx Outdated
<div className='flex items-center justify-center gap-2'>
<Loader variant='warning' />
<p className='typeset-heading text-theme-warning-600 dark:text-theme-warning-200'>
This transaction is pending confirmation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use a translation

src/pages/TransactionApproved.tsx Outdated
<div className='flex items-center justify-center gap-2'>
<Loader variant='warning' />
<p className='typeset-heading text-theme-warning-600 dark:text-theme-warning-200'>
This transaction is pending confirmation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use a translation

@ItsANameToo ItsANameToo merged commit 5d18d0a into develop Mar 28, 2024
4 checks passed
@ItsANameToo ItsANameToo deleted the feat/add-tx-pending-state branch March 28, 2024 15:35
@ItsANameToo ItsANameToo added this to the 1.7.0 milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsANameToo ItsANameToo ItsANameToo approved these changes

@samharperpittam samharperpittam samharperpittam approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shahin-hq @ItsANameToo @samharperpittam