refactor: favicon color-based border #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsANameToo
requested changes
Apr 2, 2024
| @@ -0,0 +1,7 @@ | |||
| export const convertHexToRGBA = (hex: string, opacity: string): string => { | |||
There was a problem hiding this comment.
please add a utils testcase for this as well
| > | ||
| <img className='h-full w-full object-contain' src={appLogo} alt={alt || appName} /> | ||
| </div> | ||
| <Color src={appLogo} crossOrigin='anonymous' format='hex'> |
There was a problem hiding this comment.
this doesn't seem to apply to the "connected apps" list as it still has the grey background there at all times
ItsANameToo
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[connections] change circle color based on favicon color
Summary
color-thief-reacthas been installed and implemented to get the predominant color from the favicon to implement it in the border.convertToRgbautil method to apply opacity to the hex color we get from color-thief.Checklist
pnpm devandpnpm dev:barework as intended