Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touchpad After sleep stop working #2

Closed
Ardentwheel opened this issue Oct 11, 2020 · 6 comments
Closed

Touchpad After sleep stop working #2

Ardentwheel opened this issue Oct 11, 2020 · 6 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@Ardentwheel
Copy link
Owner

After sleep Touchpad stop working

As we change SHPO (GPDI, Zero) -> SHPO (GPDI, One) to made Touchpad worked,
there's still have warning on the log sudo dmesg | grep -i voodoo

VoodooI2CControllerNub::pci8086,34e8 SSCN not implemented in ACPI tables
VoodooI2CControllerNub::pci8086,34e8 FMCN not implemented in ACPI tables

In OEM DSDT there's SSCN & FMCN

If (USTP) {
Scope (_SB.PCI0.I2C0) {
Method (SSCN, 0, NotSerialized) { Return (PKG3 (SSH0, SSL0, SSD0)) }
Method (FMCN, 0, NotSerialized) { Return (PKG3 (FMH2, FML2, FMD2)) }}}

According #1 VoodooSMBus/VoodooRMI#67 (comment)

the problem seems to be the default clock speed timing of I2C controller
but voodooi2c fine the SSCN & FMCN,
so I change Method SSCN & FMCN to XSCN & XMCN, And add:

External (_SB_.PCI0.I2C3, DeviceObj)
Scope (_SB.PCI0.I2C3)
{
    Name (SSCN, Package (0x03) {
        0x01B0, 
        0x01FB, 
        0x1E
        })
    Name (FMCN, Package (0x03) {
        0x48, 
        0xA0, 
        0x1E
    })
}

warning on the log about not implemented in ACPI tables is gone,

but after sleep Touchpad still stop working, maybe the value not right

Thought Or Suggestion?

@m0d16l14n1
@ben9923
@zhen-zen

@Ardentwheel Ardentwheel added bug Something isn't working help wanted Extra attention is needed labels Oct 11, 2020
@Ardentwheel Ardentwheel pinned this issue Oct 11, 2020
@Ardentwheel Ardentwheel modified the milestone: fsdasf Oct 11, 2020
@m0d16l14n1
Copy link
Collaborator

m0d16l14n1 commented Oct 11, 2020

You can get the rid of that SSCN/FMCN warning if you set USTP to "One" + rename patch, that's how we did that with Ben. Btw, touchpad is working with or without that patch to enable SSCN/FMCN.

But still, there is a problem with touchpad after sleep-wake cycle for sure. I saw, that we have some serial timings for touchpad. Maybe we should play around them?

IMG_1457

@m0d16l14n1
Copy link
Collaborator

Checked the polling mode - still no touchpad after sleep at all.

@m0d16l14n1
Copy link
Collaborator

@m0d16l14n1
Copy link
Collaborator

Touchpad isn't fixed for that moment, but there is a way to make it work after sleep process.

  1. Disable SIP
  2. sudo kextunload -b com.alexandred.VoodooI2CHID
    sudo kextunload -b com.alexandred.VoodooI2C
  3. Navigate to the directory with the kexts
    sudo chown -R root:wheel VoodooI2C.kext VoodooI2CHID.kext
    sudo kextutil -d VoodooI2C.kext VoodooI2CHID.kext

I will try to automate that process after sleep, to not to do that manually after every wake process. I will attach script, once it done.

@m0d16l14n1
Copy link
Collaborator

Big update!

VoodooI2C/VoodooI2C#399 (comment)

@m0d16l14n1
Copy link
Collaborator

Fixed in VoodooI2C/VoodooI2CHID#45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants