Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox download #62

Merged
merged 14 commits into from
Apr 14, 2018
Merged

Firefox download #62

merged 14 commits into from
Apr 14, 2018

Conversation

Hi-Fi
Copy link
Contributor

@Hi-Fi Hi-Fi commented Aug 8, 2017

@Hi-Fi
Copy link
Contributor Author

Hi-Fi commented Aug 8, 2017

Deployment to Sonatype seems to be broken

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:2.7:deploy (default-deploy) on project driver-binary-downloader-maven-plugin: Failed to deploy artifacts: Could not transfer artifact com.lazerycode.selenium:driver-binary-downloader-maven-plugin:jar:DEV-20170808.160728-19 from/to sonatype-nexus-snapshots (https://oss.sonatype.org/content/repositories/snapshots/): Failed to transfer file: https://oss.sonatype.org/content/repositories/snapshots/com/lazerycode/selenium/driver-binary-downloader-maven-plugin/DEV-SNAPSHOT/driver-binary-downloader-maven-plugin-DEV-20170808.160728-19.jar. Return code is: 401, ReasonPhrase: Unauthorized. -> [Help 1]

Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will be easier for Ardesco to review this if you ensure that you use the same formatting as the original. Just from looking at the diff it is hard to see what has actually changed.

This seems to be caused by using tabs rather then spaces as well as a different javadoc layout. Both should be a setting in your IDE.

@Hi-Fi
Copy link
Contributor Author

Hi-Fi commented Sep 19, 2017

Linux version requires some checks, too, so checking those same time as formatting.

@Hi-Fi
Copy link
Contributor Author

Hi-Fi commented Sep 22, 2017

Linux version working, and format (mostly) same as original one.

@Hi-Fi
Copy link
Contributor Author

Hi-Fi commented Oct 31, 2017

Any issues with this? There's quite a lot of logging when downloading full browsers, but i think it might be also OK as that extraction information is just information.

@Ardesco
Copy link
Owner

Ardesco commented Nov 6, 2017

Looks ok, however the filerepository.xml has not been updated

@Hi-Fi
Copy link
Contributor Author

Hi-Fi commented Nov 6, 2017

I'll fix that later today. For Linux it's easy (as Firefox is distributed as tarball), but for Windows and Mac I have to probably check some portable Firefox download location.

@Hi-Fi
Copy link
Contributor Author

Hi-Fi commented Feb 13, 2018

Would this be now merge- and releaseable?

@Ardesco Ardesco merged commit c4103c1 into Ardesco:master Apr 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants