-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firefox download #62
Firefox download #62
Conversation
Hi-Fi
commented
Aug 8, 2017
- Fixes Support for (standalone) browser download #52
+ FIxed path in test to use File.separator (fixes tests in Windows)
Deployment to Sonatype seems to be broken
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it will be easier for Ardesco to review this if you ensure that you use the same formatting as the original. Just from looking at the diff it is hard to see what has actually changed.
This seems to be caused by using tabs rather then spaces as well as a different javadoc layout. Both should be a setting in your IDE.
Linux version requires some checks, too, so checking those same time as formatting. |
Linux version working, and format (mostly) same as original one. |
Any issues with this? There's quite a lot of logging when downloading full browsers, but i think it might be also OK as that extraction information is just information. |
Looks ok, however the filerepository.xml has not been updated |
I'll fix that later today. For Linux it's easy (as Firefox is distributed as tarball), but for Windows and Mac I have to probably check some portable Firefox download location. |
…r-plugin into firefoxDownload
…r-plugin into firefoxDownload
Would this be now merge- and releaseable? |