Peaks

[napcode]

This fixes cases where audiosources could end up using the wrong peakfile:
Mantis issue: 0005745

• Create a session
• Drag and drop sourcefile 1 named X from Path A to track Y
• Drag and drop sourcefile 2 named X from Path B to track Y
• Save and reopen session
• Media item for sourcefile 2 will rendered using peakfile from sourcefile 1

Notes:

• This renders existing peakfiles invalid. New files will be created.
• Embedded sources do not trigger recreation of peakfiles when project folder has been moved.

Thanks and let me know if there is anything wrong.

[x42]

Thanks for digging into this.

Looks good in general, but I'd like to re-read and test-run.
Please stay tuned for a few days until ardour-devs return from holidays; most of us are currently traveling.

[napcode]

Sure. Please do. I appreciate any feedback.

[x42]

the 2nd commit hides an overloaded virtual function:

libs/ardour/ardour/audiofilesource.h:43:14: warning: 'ARDOUR::AudioFileSource::find_broken_peakfile' hides overloaded virtual function [-Woverloaded-virtual]
 std::string find_broken_peakfile (const std::string& missing_peak_path,
             ^
libs/ardour/ardour/audiosource.h:140:22: note: hidden overloaded virtual function 'ARDOUR::AudioSource::find_broken_peakfile' declared here: type mismatch at 1st parameter ('std::string' (aka 'basic_string<char>') vs 'const std::string &' (aka 'const basic_string<char> &'))
 virtual std::string find_broken_peakfile (std::string ,
                     ^