fix crash in Keyboard Shortcut Widget / "Print Bindings" #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This rather seems to hide an issue. If it is possible that path, keys and labels can get out of sync, that would be an issue elsewhere. |
|
Looks like this is due to recent re-design of the ActionManager. @pauldavisthefirst is this an oversight or incomplete work-in-progress? |
|
grrr, sorry, seems I've messed-up my repo. My bad. Trying to fix that. |
pauldavisthefirst
pushed a commit
that referenced
this pull request
Mar 9, 2019
(ardour -b or Keyboard-Shortcuts > Print Bindings) see also #447
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to reproduce the crash:
open the "Keyboard Shortcut Widget", click on "Print Bindings"
The fix add checks on all iterators in the loop, so that each of them is always valid.
I don't have the domain-knowledge to know if an other (underlying) bug exist: should those 3 collections have the exact same number of elements?