Windows related bugfixes for the WebSockets Server #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Escape path strings in surfaces.json Default to index.html in mount points
Also include VCAs when sending strip descriptions
lucianoiam
referenced
this pull request
Apr 21, 2020
This eventually needs a better solution, special casing VCAs on the top-level.
This allows to hide the panner for example
|
The Windows build still has issues when serving files as of 6.0 RC1-44. Assuming that build includes commit cc08a2d in this PR Unless index.html is appended to each surface URL a 404 is returned. This is handled by libwebsockets and never happened on other platforms. Probably needs dedicated debugging on a Windows environment.
|
|
The "Escape path strings in surfaces.json" patch was also needed and worked, though. |
lucianoiam
added a commit
to lucianoiam/ardour
that referenced
this pull request
Apr 24, 2020
Avoid 404s when following surface links while the issue in Ardour#491 is better investigated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds the ability to interact with VCA strips